don't rely on distutils.sysconfig directly to determine Python lib dir #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewed, looks good. |
…hrough run_cmd to get correct version
|
@fgeorgatos: You reviewed too early. ;-) |
| """Prepare by determining Python site lib dir.""" | ||
|
|
||
| # we can't simply import distutils.sysconfig, because then we would be talking to the system Python | ||
| cmd = ' '.join(['python -c "', |
There was a problem hiding this comment.
if you think it helps readability, being the dict one line below (as we do in other dictionary items);
other than that, I have no more remarks, at least from a visual check of the code. It seems like a code factorization effort, good.
|
@boegel looks fine by me |
|
Fixed bugs, tested, works as expected now, so merging it in. |
boegel
added a commit
that referenced
this pull request
Mar 28, 2013
don't rely on distutils.sysconfig directly to determine Python lib dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't rely on
distutils.sysconfig.get_python_lib()directly to determine the Python library dir 'lib/python%(python_version)s/site-packages', since that will return the value for the system Python, not for the Python module that was loaded.