Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checksum for patch in make 4.2.1 easyconfig using GCC/7.3.0-2.30 #12223

Merged
merged 1 commit into from Feb 21, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Feb 21, 2021

(created using eb --new-pr)

The patch file was tweaked in #11371, but the checksum wasn't updated consistently...

I'm enhancing the easyconfigs test suite in #12221 to avoid mistakes like this to go unnoticed...

@boegel
Copy link
Member Author

boegel commented Feb 21, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2614.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0102f815170ad7e6491554373bafe7e5 for a full test report.

@boegel boegel added the bug fix label Feb 21, 2021
@boegel boegel added this to the 4.3.3 (next release) milestone Feb 21, 2021
@boegel boegel changed the title fix checksum for patch in make 4.2 easyconfig using GCC/7.3.0-2.30 fix checksum for patch in make 4.2.1 easyconfig using GCC/7.3.0-2.30 Feb 21, 2021
@boegel boegel force-pushed the 20210221185043_new_pr_make421 branch from 7800567 to 658f68e Compare February 21, 2021 18:02
@boegel boegel added this to In progress in next EasyBuild release (v4.3.3?) via automation Feb 21, 2021
Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

next EasyBuild release (v4.3.3?) automation moved this from In progress to Reviewer approved Feb 21, 2021
@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/b6dc285e2246aeba4774a66fdbcc6b43 for a full test report.

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit 77e85d3 into easybuilders:develop Feb 21, 2021
next EasyBuild release (v4.3.3?) automation moved this from Reviewer approved to Done Feb 21, 2021
@boegel boegel deleted the 20210221185043_new_pr_make421 branch February 21, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants