Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GCC as toolchain for serial variants of HDF5, since it has a FORTRAN API #17221

Merged
merged 1 commit into from Jan 27, 2023

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Jan 27, 2023

Fixes #17219

I've left the merged v1.13.1 there as I can't be sure of the impact of removing it. The only easyconfig that depends on one of these (in our releases) is h5py-2.10.0-foss-2019b-serial-Python-3.7.4.eb and since that uses the same compiler there is no material change.

@ocaisa
Copy link
Member Author

ocaisa commented Jan 27, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=17221 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17221 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10067

Test results coming soon (I hope)...

- notification for comment with ID 1406457685 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/232405a870a8bdaaf8e2b7ad532d6f11 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Jan 27, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17221 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17221 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2113

Test results coming soon (I hope)...

- notification for comment with ID 1406496570 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/78ac32f9fc3c6f4994e0dcc6f104f505 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Jan 27, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
himem06.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/89c195bfef96156d40032319f24b7d86 for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Member

jfgrimm commented Jan 27, 2023

Going in, thanks @ocaisa!

@jfgrimm jfgrimm merged commit cbf1c2c into easybuilders:develop Jan 27, 2023
@boegel boegel changed the title HDF5 has a FORTRAN api so must be at compiler level use GCC as toolchain for serial variants of HDF5, since it has a FORTRAN API Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merged HDF5-serial files built with GCCcore instead of being compiler dependent
3 participants