Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https in homepage + source URL for GenomeThreader 1.7.3 #17338

Merged

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Feb 15, 2023

(created using eb --new-pr)

@smoors smoors added the bug fix label Feb 15, 2023
@smoors
Copy link
Contributor Author

smoors commented Feb 15, 2023

@boegelbot: please test @ generoso EB_ARGS="--force-download"

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=17338 EB_ARGS="--force-download" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17338 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10241

Test results coming soon (I hope)...

- notification for comment with ID 1431444877 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/29c3a4dee77edb6039feea14831abcd6 for a full test report.

@smoors smoors added this to the next release (4.7.1?) milestone Feb 15, 2023
@boegel boegel changed the title use https for GenomeThreader use https in homepage + source URL for GenomeThreader 1.7.3 Feb 15, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 15, 2023

Going in, thanks @smoors!

@boegel boegel merged commit d1c8ed7 into easybuilders:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants