Skip to content

include MPFR 4.1.0 patch in MPFR 4.2.0 easyconfigs to fix failing tsprintf test with glibc >= 2.37 #19438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Dec 18, 2023

This patch was originally added to MPFR 4.1.0 easyconfigs (in #18746), but was removed in version 4.2.0. However, we are still seeing failures for the tsprintf test in the EESSI environment (glibc 2.37) for version 4.2.0.

I was just reading the MPFR changelog and this page is really confusing; the page for 4.2.1 (https://www.mpfr.org/mpfr-4.2.1/#changes) refers to the changelog page of 4.2.0 (https://www.mpfr.org/mpfr-4.2.0/#fixed), and the latter does seem to suggest that the bug has been solved (first item in the list). However, the code does not confirm this:

4.1.0 -> https://gitlab.inria.fr/mpfr/mpfr/-/blob/4.1.0/tests/tsprintf.c?ref_type=tags#L1653
4.2.0 -> https://gitlab.inria.fr/mpfr/mpfr/-/blob/4.2.0/tests/tsprintf.c?ref_type=tags#L1717
4.2.1 -> https://gitlab.inria.fr/mpfr/mpfr/-/blob/4.2.1/tests/tsprintf.c?ref_type=tags#L1775

So, it looks like it's only fixed in 4.2.1. Also the source tarballs confirm this. Hence, I'm applying the 4.1.0 patch to the 4.2.0 easyconfigs as well.

@bedroge bedroge added bug fix EESSI Related to EESSI project labels Dec 18, 2023
@bedroge
Copy link
Contributor Author

bedroge commented Dec 18, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=19438 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19438 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12430

Test results coming soon (I hope)...

- notification for comment with ID 1860044341 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Contributor Author

bedroge commented Dec 18, 2023

Test report by @bedroge
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/f9ee22faff34deb41d9a5fdcd2149983 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Dec 18, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19438 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19438 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3934

Test results coming soon (I hope)...

- notification for comment with ID 1860085160 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/9ca09676b11e5402a8991a9d1a6193e3 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Dec 18, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=19438 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19438 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12433

Test results coming soon (I hope)...

- notification for comment with ID 1861717304 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19438 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19438 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12436

Test results coming soon (I hope)...

- notification for comment with ID 1862540434 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/96349752eb4b18a330d1fa730fdd314b for a full test report.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/a9ccc2951606f31fbceaba07e583d7af for a full test report.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the next release (4.9.0?) milestone Dec 19, 2023
@casparvl
Copy link
Contributor

Going in, thanks @bedroge!

@casparvl casparvl merged commit d54ab0a into easybuilders:develop Dec 19, 2023
@bedroge bedroge deleted the MPFR_fix_tsprintf_test branch December 19, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants