-
Notifications
You must be signed in to change notification settings - Fork 743
include MPFR 4.1.0 patch in MPFR 4.2.0 easyconfigs to fix failing tsprintf test with glibc >= 2.37 #19438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@boegelbot please test @ generoso |
@bedroge: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1860044341 processed Message to humans: this is just bookkeeping information for me, |
Test report by @bedroge |
@boegelbot please test @ jsc-zen2 |
@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1860085160 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@bedroge: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1861717304 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1862540434 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @casparvl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Going in, thanks @bedroge! |
This patch was originally added to MPFR 4.1.0 easyconfigs (in #18746), but was removed in version 4.2.0. However, we are still seeing failures for the
tsprintf
test in the EESSI environment (glibc 2.37) for version 4.2.0.I was just reading the MPFR changelog and this page is really confusing; the page for 4.2.1 (https://www.mpfr.org/mpfr-4.2.1/#changes) refers to the changelog page of 4.2.0 (https://www.mpfr.org/mpfr-4.2.0/#fixed), and the latter does seem to suggest that the bug has been solved (first item in the list). However, the code does not confirm this:
4.1.0 -> https://gitlab.inria.fr/mpfr/mpfr/-/blob/4.1.0/tests/tsprintf.c?ref_type=tags#L1653
4.2.0 -> https://gitlab.inria.fr/mpfr/mpfr/-/blob/4.2.0/tests/tsprintf.c?ref_type=tags#L1717
4.2.1 -> https://gitlab.inria.fr/mpfr/mpfr/-/blob/4.2.1/tests/tsprintf.c?ref_type=tags#L1775
So, it looks like it's only fixed in 4.2.1. Also the source tarballs confirm this. Hence, I'm applying the 4.1.0 patch to the 4.2.0 easyconfigs as well.