Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{vis}[foss/2018a] opencv_contrib v3.4.1 #6441

Merged
merged 2 commits into from Jun 10, 2018
Merged

{vis}[foss/2018a] opencv_contrib v3.4.1 #6441

merged 2 commits into from Jun 10, 2018

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Jun 8, 2018 •
edited

(created using eb --new-pr)
this easyconfig includes the opencv_contrib modules into OpenCV

@smoors
Copy link
Contributor Author

smoors commented Jun 8, 2018 •
edited

note: because eb tries to be too clever finding the sources, I had to use a hack ;)
imho eb should keep sources and source_urls in sync.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 11 out of 11 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/79cc9479e6366c5355599a84b179893e for a full test report.

@verdurin verdurin added the new label Jun 10, 2018
@verdurin verdurin added this to the 3.6.2 milestone Jun 10, 2018
verdurin
verdurin approved these changes Jun 10, 2018
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @smoors!

@verdurin verdurin merged commit 7ac9f8f into easybuilders:develop Jun 10, 2018
@easybuilders easybuilders deleted a comment from boegelbot Jun 10, 2018
@smoors smoors deleted the 20180608161918_new_pr_opencv_contrib341 branch January 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verdurin verdurin verdurin approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smoors @verdurin