New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix checksums for pkgmaker, rngtools & RcppProgress extensions in R 3.4.3 easyconfigs #6815
fix checksums for pkgmaker, rngtools & RcppProgress extensions in R 3.4.3 easyconfigs #6815
Conversation
…already present in R-3.4.4 EasyConfigs for newer toolchains, but wasn't updated (yet) for R-3.4.3
I actually ran into this too yesterday, not sure how it managed to go unnoticed... (cfr. #6446) @casparvl There's actually two more in these easyconfigs: diff --git a/easybuild/easyconfigs/r/R/R-3.4.3-foss-2017b-X11-20171023.eb b/easybuild/easyconfigs/r/R/R-3.4.3-foss-2017b-X11-20171023.eb
index f07ec5672..379266150 100644
--- a/easybuild/easyconfigs/r/R/R-3.4.3-foss-2017b-X11-20171023.eb
+++ b/easybuild/easyconfigs/r/R/R-3.4.3-foss-2017b-X11-20171023.eb
@@ -690,10 +690,10 @@ exts_list = [
'checksums': ['5d8be59ba791987b2400e9e8eaaac614cd544c1aece785ec4782ea6d5ea00efb'],
}),
('pkgmaker', '0.22', {
- 'checksums': ['19ad78c16bd5757333e7abbd5eebcec081deb494c9a4b6eec6919a3747b3386f'],
+ 'checksums': ['05da8b6c0e6828676aeb3faa05ea6e1025b95efffde4820e9ae2b938dbb3027e'],
}),
('rngtools', '1.2.4', {
- 'checksums': ['27019835b750f470b13dbb7fecd3b839a61b52774e23fffa191f919533768fb9'],
+ 'checksums': ['17409ada52a2405efa931b5895254cac0e28518a0d41f05012ba3f8af8af3556'],
}),
('doParallel', '1.0.11', {
'checksums': ['4ccbd2eb46d3e4f5251b0c3de4d93d9168b02bb0be493656d6aea236667ff76a'],
@@ -1522,7 +1522,7 @@ exts_list = [
'checksums': ['7379b21d1176db5769f5cac858dd12c975736e80a600870180cec9625cf51047'],
}),
('RcppProgress', '0.4', {
- 'checksums': ['3b1ecc82ced98eb481819a28737dac3658586e11ad16a92abd14c4649ae15e25'],
+ 'checksums': ['706e14360dbc5976db05c2ac6692c3279c0f8c95e72bf9d4becd9e1348025e3e'],
}),
('sn', '1.5-1', {
'checksums': ['fcfc077a2c1eb35b1ed875fea296b225540aefb05564cbb54477f266a0a2f850'],
diff --git a/easybuild/easyconfigs/r/R/R-3.4.3-intel-2017b-X11-20171023.eb b/easybuild/easyconfigs/r/R/R-3.4.3-intel-2017b-X11-20171023.eb
index 4d6581e3a..8160b831f 100644
--- a/easybuild/easyconfigs/r/R/R-3.4.3-intel-2017b-X11-20171023.eb
+++ b/easybuild/easyconfigs/r/R/R-3.4.3-intel-2017b-X11-20171023.eb
@@ -702,10 +702,10 @@ exts_list = [
'checksums': ['5d8be59ba791987b2400e9e8eaaac614cd544c1aece785ec4782ea6d5ea00efb'],
}),
('pkgmaker', '0.22', {
- 'checksums': ['19ad78c16bd5757333e7abbd5eebcec081deb494c9a4b6eec6919a3747b3386f'],
+ 'checksums': ['05da8b6c0e6828676aeb3faa05ea6e1025b95efffde4820e9ae2b938dbb3027e'],
}),
('rngtools', '1.2.4', {
- 'checksums': ['27019835b750f470b13dbb7fecd3b839a61b52774e23fffa191f919533768fb9'],
+ 'checksums': ['17409ada52a2405efa931b5895254cac0e28518a0d41f05012ba3f8af8af3556'],
}),
('doParallel', '1.0.11', {
'checksums': ['4ccbd2eb46d3e4f5251b0c3de4d93d9168b02bb0be493656d6aea236667ff76a'],
@@ -1559,7 +1559,7 @@ exts_list = [
'checksums': ['7379b21d1176db5769f5cac858dd12c975736e80a600870180cec9625cf51047'],
}),
('RcppProgress', '0.4', {
- 'checksums': ['3b1ecc82ced98eb481819a28737dac3658586e11ad16a92abd14c4649ae15e25'],
+ 'checksums': ['706e14360dbc5976db05c2ac6692c3279c0f8c95e72bf9d4becd9e1348025e3e'],
}),
('sn', '1.5-1', {
'checksums': ['fcfc077a2c1eb35b1ed875fea296b225540aefb05564cbb54477f266a0a2f850'], |
You're right, I fixed pkgmaker, filed the pull request assuming 'this is why it doesn't build', only to run into the next checksum the next day. Ok, so what now? Should I change these things and then update my pull request? (and how can the Travis build have passed while two of my checksums where still incorrect?) |
@casparvl Yes, updating this PR to fix the remaining checksums make sense, you can use Travis only runs the lightweight unit tests on the easyconfigs, it doesn't do the actual build of the easyconfigs or even download the sources (let alone verify the checksums). Actual test builds are triggered by humans, who can submit test reports for a PR using It does verify that SHA256 checksums are there, but it doesn't verify the checksums themselves (since that implies downloading everything for all easyconfigs, which is not feasible on Travis). |
also fix checksums for rngtools & RcppProgress in R 3.4.3 easyconfigs
Thanks @casparvl! |
(created using
eb --new-pr
)