Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{phys}[intel/2018a] CHERAB v1.2.0 and Raysect v0.6.0 for Python/3.6.6 #7141

Merged
merged 10 commits into from Dec 11, 2020

Conversation

SimonPinches
Copy link
Contributor

Raysect is a ray-tracing code and CHERAB is a plasma spectroscopy code built upon it.

@boegel boegel added this to To do in merge sprint (Oct'20) Sep 23, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 11, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 11, 2020
@lexming
Copy link
Contributor

lexming commented Dec 11, 2020

@SimonPinches as part of the merge spring I have reviewed this PR for Raysect and CHERAB. To be able to merge it, I proceeded with the following changes:

  • removed the three pairs of versions of Raysect/CHERAB as it is only allowed to have a single dependency per package per toolchain. I favoured the last version of CHERAB v1.2.0 depending on Raysect v0.6.0.
  • moved to intel/2018b to fulfil the requirement on Cython >= 0.28
  • fixed sanity checks and added the new parameters needed by PythonPackages in EB

I hope that you agree with these changes

@lexming lexming added the new label Dec 11, 2020
@lexming lexming added this to the next release (4.3.3?) milestone Dec 11, 2020
@lexming lexming changed the title {phys} [intel/2018a] CHERAB v1.0.1 and Raysect v0.5.4 for Python/3.6.4 {REVIEW} {phys} [intel/2018a] CHERAB v1.2.0 and Raysect v0.6.0 for Python/3.6.6 Dec 11, 2020
@lexming
Copy link
Contributor

lexming commented Dec 11, 2020

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node367.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/786f782649c16d6e49d1b8e380bff9c8 for a full test report.

@boegel boegel changed the title {phys} [intel/2018a] CHERAB v1.2.0 and Raysect v0.6.0 for Python/3.6.6 {phys}[intel/2018a] CHERAB v1.2.0 and Raysect v0.6.0 for Python/3.6.6 Dec 11, 2020
@boegel
Copy link
Member

boegel commented Dec 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2707.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/a98c368d1431f1c98a4319d6efbc371d for a full test report.

@boegel
Copy link
Member

boegel commented Dec 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3409.kirlia.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 3.6.8
See https://gist.github.com/42876a28c1a94b95cf230d17e67dfd96 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Dec 11, 2020

Going in, thanks @SimonPinches!

@boegel boegel merged commit fd6eafe into easybuilders:develop Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants