New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{chem}[foss/2018b,intel/2018b] GPAW v1.5.2 #7570
{chem}[foss/2018b,intel/2018b] GPAW v1.5.2 #7570
Conversation
…-intel-2018b-Python-3.6.6.eb
A new version of GPAW has been released. |
The ASE version conflict is not really relevant, since it is only ASAP3 and GPAW using the old version, and I have uploaded new versions of both using the new ASE. See PR #7569 |
@schiotz We can consider adding an exception in the tests for The idea is that we try to keep easyconfigs that use the same toolchain compatible with each other. In some cases that doesn't make much sense of course, like there's no point in keeping It's more complex than this though, since We're aware this is quite limiting, but we've learned the hard way that not using this policy results in a lot of pain later (see for example the problems with Of course, |
@boegel We could of course just make the new version with a new toolchain, but that requires installing new versions of everything. Locally we have informally decided to skip every second toolchain to keep the number of modules down. On the other hand, I see your points about version consistency. And I fully understand if you are reluctant to modify the test suite to special-case ASE, since that kind of stuff tends to become unmaintainable. Of course, if it is just adding a line to a config file... If need be, we can locally install from this PR (already done, actually), and I can make a new PR for the 2019a toolchains. |
Test report by @schiotz |
This one should be dropped and changed to 1.5.2 instead. |
@schiotz If Or maybe we should mention the |
@boegel I think the risk of ASE conflicts is relatively small so far, so I would prefer to not add an ASE version in the versionsuffix. But it is not a strong preference, your call. But in any case, @akesandgren is right: this version should be replaces with 1.5.2 due to a serious bug in 1.5.1. I am currently making and testing new easyblocks, and can either update this PR or make a new one. |
@boegel @akesandgren WARNING: |
Test report by @akesandgren |
easybuild/easyconfigs/g/GPAW/GPAW-1.5.2-foss-2018b-Python-3.6.6.eb
Outdated
Show resolved
Hide resolved
Of course, my bad. Thanks, @akesandgren |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we now have easyconfigs for the same toolchain but versions 1.4.0 and 19.8.1 @schiotz I'm closing this PR, but if this specific version is relevant, do feel free to reopen it |
(created using
eb --new-pr
)