Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[foss/2016b,foss/2018b] GEMMA 0.97 + 0.98.1 #8270

Merged
merged 5 commits into from Aug 19, 2019
Merged

{bio}[foss/2016b,foss/2018b] GEMMA 0.97 + 0.98.1 #8270

merged 5 commits into from Aug 19, 2019

Conversation

pescobar
Copy link
Member

@pescobar pescobar commented May 8, 2019

No description provided.

@pescobar pescobar mentioned this pull request May 8, 2019
Closed
@boegel boegel added the new label May 8, 2019
@boegel boegel added this to the 3.x milestone May 8, 2019
@boegel boegel changed the title added easyconfig for GEMMA {bio}[foss/2016b] GEMMA 0.97 May 8, 2019
@boegel
Copy link
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2006.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b4a459a83d3fb8a5d650db397ace306b for a full test report.

@pescobar
Copy link
Member Author

pescobar commented May 8, 2019

Test report by @pescobar
FAILED
Build succeeded for 0 out of 1 (2 easyconfigs in this PR)
login20.cluster.bc2.ch - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/f38e6a540603737c7c13fbf4ec7a87e8 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2434.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/b27b4447b45a72a861ffb5b1639a78af for a full test report.

@pescobar
Copy link
Member Author

pescobar commented May 8, 2019

Test report by @pescobar
FAILED
Build succeeded for 0 out of 1 (2 easyconfigs in this PR)
login20.cluster.bc2.ch - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7102ff95ca34e5b44373c577a6b3844b for a full test report.

@boegel boegel changed the title {bio}[foss/2016b] GEMMA 0.97 {bio}[foss/2016b,foss/2018b] GEMMA 0.97 + 0.98.1 May 8, 2019
@boegel
Copy link
Member

boegel commented May 8, 2019

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
node2006.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2f8cf534c62fbcb9b0f759c8f40f70f2 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2019

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
node2434.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/67dc169f88d15d79500c36a4e9d6dcc6 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2019

@pescobar So what's the deal with this? :)

akesandgren
akesandgren previously requested changes May 10, 2019
View reviewed changes
easybuild/easyconfigs/g/GEMMA/GEMMA-0.98.1-foss-2018b.eb Outdated
@@ -23,7 +23,6 @@ builddependencies = [

dependencies = [
('GSL', '2.5'),
('zlib', '1.2.11'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If GEMMA uses zlib, then zlib should be an explicit dependency and not implicit from the toolchain.

@smoors
Copy link
Contributor

smoors commented May 30, 2019

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
nic424 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/c99b5c6a34420bd072129f01366526f8 for a full test report.

@smoors
Copy link
Contributor

smoors commented May 30, 2019

@boegel this needs the workaround for OpenBLAS to pass the tests (which is quite worrisome):
#8396

smoors
smoors previously approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented May 30, 2019

@pescobar hm I missed the last comment of @akesandgren : please re-add the zlib dep?

@smoors
Copy link
Contributor

smoors commented Aug 19, 2019

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
nic407 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/aa02ed83ee18063d680e29300533ad12 for a full test report.

smoors
smoors approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors dismissed akesandgren’s stale review August 19, 2019 08:08

comments addressed

@smoors
Copy link
Contributor

smoors commented Aug 19, 2019

Going in, thanks @pescobar!

@smoors smoors merged commit bae6f54 into easybuilders:develop Aug 19, 2019
@boegel boegel modified the milestones: 3.x, 3.9.4 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

@akesandgren akesandgren akesandgren left review comments

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
3.9.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pescobar @boegel @smoors @akesandgren