Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[dummy/dummy] SeqAn3 v3.0.0 #8651

Merged

Conversation

cmeesters
Copy link
Contributor

(created using eb --new-pr)

@cmeesters
Copy link
Contributor Author

I erased the gcc dependency, 'cause it is a quasi dependency, but not a strict one.

Micket
Micket previously requested changes Aug 2, 2019
easybuild/easyconfigs/s/seqan/seqan-3.0.0.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/s/seqan/seqan-3.0.0.eb Outdated Show resolved Hide resolved
@cmeesters
Copy link
Contributor Author

@Micket

Thank you. You are right.

As for the naming: I did my own distinction between apps (CamelCase) and the lib (lower case) but that does not apply to eb.

As for the dependency: The SeqAn developers state gcc >7 and cmake as dependencies, yet these are dependencies to work with the (header only) library and not to install it. Please do not confuse the library with the SeqAn-2.4.0-xxx-eb configs in the 'bio' moduleclass - these install applications.

It is my mistake having included dependencies where non are.

@Micket
Copy link
Contributor

Micket commented Aug 6, 2019

@cmeesters You forgot to remove the old eb config from the PR.

Sometimes header-only libraries still actually use CMake just to install itself. That's what I thought was going on here (and, in which case, you could use a "build" dep for this). Is it not?

@cmeesters
Copy link
Contributor Author

@Micket

No, it's just a copy-step.

How can one remove an old file within this thread?

@boegel
Copy link
Member

boegel commented Aug 6, 2019

@cmeesters You can prefix the filename to remove with a colon : when using eb --update-pr, see also https://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#deleting-easyconfig-files-or-patches

@easybuilders easybuilders deleted a comment from boegelbot Aug 6, 2019
@boegel boegel changed the title {lib}[dummy/dummy] seqan v3.0.0 {lib}[dummy/dummy] SeqAn3 v3.0.0 Aug 6, 2019
@boegel boegel added the new label Aug 6, 2019
@boegel boegel modified the milestones: 3.x, next release (3.9.4?) Aug 6, 2019
@boegel
Copy link
Member

boegel commented Aug 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3150.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/c00a38705a1dd77a8f1eae50a95f8614 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2412.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ddd36f245388c24b57937fba0b099149 for a full test report.

@boegel boegel dismissed Micket’s stale review August 8, 2019 21:45

requested changes made

@boegel
Copy link
Member

boegel commented Aug 8, 2019

Going in, thanks @cmeesters!

@boegel boegel merged commit e7a7953 into easybuilders:develop Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants