Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose a easyconfig from a PR #1132

Merged
merged 6 commits into from Jan 9, 2015
Merged

Choose a easyconfig from a PR #1132

merged 6 commits into from Jan 9, 2015

Conversation

wpoely86
Copy link
Member

@wpoely86 wpoely86 commented Jan 9, 2015

eb --from-pr XX file.eb now works. It will only install the file.eb
easyconfig but using all deps in the PR.

@wpoely86
Choose a easyconfig from a PR
3f07641 
eb --from-pr XX file.eb now works. It will only install the file.eb
easyconfig but using all deps in the PR.
@hpcugentbot
Copy link
Contributor

Test FAILed.

@hpcugentbot
Copy link
Contributor

Test FAILed.

fgeorgatos
fgeorgatos reviewed Jan 9, 2015
View reviewed changes
easybuild/framework/easyconfig/tools.py
@@ -282,7 +287,7 @@ def det_easyconfig_paths(orig_paths, from_pr=None, easyconfigs_pkg_paths=None):
break

# ignore subdirs specified to be ignored by replacing items in dirnames list used by os.walk
dirnames[:] = [d for d in dirnames if not d in build_option('ignore_dirs')]
dirnames[:] = [d for d in dirnames if d not in build_option('ignore_dirs')]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks for the contribution! and reviewed visually by now.

For my curiosity: the above line is only a difference in syntactic sugar or, there is some other semantic aspect to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8 was complaining that the proper way to do this is not in.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86: OK, I think from your part well done and said.

If anyone knows why pep8 triggered the warning, it would be nice to know;
perhaps code maintainability as such an expression may perhaps grow later on...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgeorgatos: I think it's about interpreting the code. not x in xs could be interpreted as not (x in xs) or (not x) in xs. You don't have that problem with x not in xs.

@boegel
Copy link
Member

boegel commented Jan 9, 2015

current behaviour:

$ eb --from-pr 1287 GCC-4.8.2.eb horton-1.0.2-goolf-1.4.10-Python-2.7.3.eb -D | egrep "/GCC|horton|Libint"
 * [x] /Users/kehoste/work/easybuild-easyconfigs/easybuild/easyconfigs/g/GCC/GCC-4.8.2.eb (module: GCC/4.8.2)
 * [ ] /Users/kehoste/work/easybuild-easyconfigs/easybuild/easyconfigs/g/GCC/GCC-4.7.2.eb (module: GCC/4.7.2)
 * [ ] /tmp/files_pr1287/Libint-2.0.3-goolf-1.4.10.eb (module: Libint/2.0.3-goolf-1.4.10)
 * [ ] /tmp/files_pr1287/horton-1.0.2-goolf-1.4.10-Python-2.7.3.eb (module: horton/1.0.2-goolf-1.4.10-Python-2.7.3)

$ eb --from-pr 1287 GCC-4.8.2.eb -D | egrep "/GCC|horton|Libint" 
CFGS=/Users/kehoste/work/easybuild-easyconfigs/easybuild/easyconfigs/g/GCC
 * [x] $CFGS/GCC-4.8.2.eb (module: GCC/4.8.2)

$ eb --from-pr 1287 -D | egrep "/GCC|horton|Libint" 
 * [ ] /Users/kehoste/work/easybuild-easyconfigs/easybuild/easyconfigs/g/GCC/GCC-4.7.2.eb (module: GCC/4.7.2)
 * [ ] /Users/kehoste/work/easybuild-easyconfigs/easybuild/easyconfigs/g/GCC/GCC-4.6.3.eb (module: GCC/4.6.3)
 * [ ] /Users/kehoste/work/easybuild-easyconfigs/easybuild/easyconfigs/g/GCC/GCC-4.8.3.eb (module: GCC/4.8.3)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-goolf-1.4.10.eb (module: Libint/1.1.4-goolf-1.4.10)
 * [ ] /tmp/files_pr1287/Libint-2.0.3-goolf-1.4.10.eb (module: Libint/2.0.3-goolf-1.4.10)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-ictce-3.2.2.u3.eb (module: Libint/1.1.4-ictce-3.2.2.u3)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-ictce-4.1.13.eb (module: Libint/1.1.4-ictce-4.1.13)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-ictce-5.3.0.eb (module: Libint/1.1.4-ictce-5.3.0)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-ictce-5.5.0.eb (module: Libint/1.1.4-ictce-5.5.0)
 * [ ] /tmp/files_pr1287/Libint-2.0.3-ictce-4.1.13.eb (module: Libint/2.0.3-ictce-4.1.13)
 * [ ] /tmp/files_pr1287/Libint-2.0.3-ictce-5.5.0.eb (module: Libint/2.0.3-ictce-5.5.0)
 * [ ] /tmp/files_pr1287/Libint-2.0.3-intel-2014b.eb (module: Libint/2.0.3-intel-2014b)
 * [ ] /tmp/files_pr1287/horton-1.0.2-goolf-1.4.10-Python-2.7.3.eb (module: horton/1.0.2-goolf-1.4.10-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.1.0-goolf-1.4.10-Python-2.7.3.eb (module: horton/1.1.0-goolf-1.4.10-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.2.0-goolf-1.4.10-Python-2.7.3.eb (module: horton/1.2.0-goolf-1.4.10-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.2.1-goolf-1.4.10-Python-2.7.3.eb (module: horton/1.2.1-goolf-1.4.10-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.0.2-ictce-4.1.13-Python-2.7.3.eb (module: horton/1.0.2-ictce-4.1.13-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.1.0-ictce-4.1.13-Python-2.7.3.eb (module: horton/1.1.0-ictce-4.1.13-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.2.0-ictce-4.1.13-Python-2.7.3.eb (module: horton/1.2.0-ictce-4.1.13-Python-2.7.3)
 * [ ] /tmp/files_pr1287/horton-1.2.1-ictce-4.1.13-Python-2.7.3.eb (module: horton/1.2.1-ictce-4.1.13-Python-2.7.3)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-gmacml-1.7.0.eb (module: Libint/1.1.4-gmacml-1.7.0)
 * [ ] /tmp/files_pr1287/Libint-1.1.4-goalf-1.1.0-no-OFED.eb (module: Libint/1.1.4-goalf-1.1.0-no-OFED)

@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member

boegel commented Jan 9, 2015

Looking great now, Jenkins is happy, so going in.

Thanks @wpoely86!

boegel added a commit that referenced this pull request Jan 9, 2015
@boegel
Merge pull request #1132 from wpoely86/select_frompr
1052764 
Choose a easyconfig from a PR
@boegel boegel merged commit 1052764 into easybuilders:develop Jan 9, 2015
@wpoely86 wpoely86 deleted the select_frompr branch January 9, 2015 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wpoely86 @hpcugentbot @boegel @fgeorgatos