New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give easyblocks the possibility to choose maxhits for run_cmd_qa #1417
Conversation
Automatic reply from Jenkins: Can I test this? |
@@ -227,7 +227,7 @@ def check_answers_list(answers): | |||
else: | |||
runLog = None | |||
|
|||
maxHitCount = 50 | |||
maxHitCount = maxhits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind renaming this to max_hit_count
while you're at it (we're trying to get rid of CamelCase throughout the whole codebase)?
or rather, just use maxhits
wherever maxHitCount
is used now, there's no need to define another variable for the same thing (since the value doesn't change afaik?)
Jenkins: ok to test |
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2130/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
@molden: ignore the failed test, the run was cancelled due to issues with Jenkins, I'll retrigger the test |
Jenkins: test this please |
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2134/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2138/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Looking great, thanks @molden! |
give easyblocks the possibility to choose maxhits for run_cmd_qa
This will give easyblocks the possibility to choose maxhits for run_cmd_qa. This is necessary for the CUDA easyblock fix (to be submitted).