pass down stdin in 'import' check for extensions during sanity check #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs enhanced tests to verify the changes (and make sure the bug being fixed here isn't re-introduced). |
|
Without the changes to the Seurat easyconfig in easybuilders/easybuild-easyconfigs#4889, the sanity check fails as it should on top of this... |
…own of stdin value to filter command
|
tests are enhanced to catch the bug @easybuilders/easybuild-framework-maintainers ready for review |
ocaisa
previously approved these changes
Aug 25, 2017
There was a problem hiding this comment.
Cached commands can be found at https://github.com/easybuilders/easybuild-framework/blob/master/easybuild/tools/run.py#L60
ocaisa
reviewed
Aug 25, 2017
| @@ -118,6 +118,22 @@ def test_run_cmd_simple(self): | |||
| self.assertEqual(True, run_cmd("echo hello", simple=True)) | |||
| self.assertEqual(False, run_cmd("exit 1", simple=True, log_all=False, log_ok=False)) | |||
|
|
|||
| def test_run_cmd_cache(self): | |||
There was a problem hiding this comment.
What about a test for the (caching of the) new inp argument to run_cmd?
There was a problem hiding this comment.
good point, added in #bc4be4154
ocaisa
approved these changes
Aug 25, 2017
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Aug 29, 2017
…-1.3.12-test.eb test easyconfig in easybuilders#2276
wpoely86
added a commit
that referenced
this pull request
Aug 29, 2017
fix test_inject_checksums that got broken by changes to toy-0.0-gompi-1.3.12-test.eb test easyconfig in PR #2276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not passing down
stdinintorun_cmdin thesanity_checkimplementation for extensions, the 'import' check for R libraries is basically being skipped...In addition, the caching mechanism for
run_cmdshould also take into account theinpargument.