add support for 'clone_into' field in git_config source spec to specify different name for top-level directory #3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is at least one software (avogadrolibs) that assumes that the directory the repo is cloned into has a different name than the upstream repo.
boegel
requested changes
Feb 16, 2022
There was a problem hiding this comment.
@akesandgren Looks good, but the test for get_source_tarball_from_git in test/framework/filetools.py should be enhanced to verify that using clone_into has the desired effect, and the documentation should be updated too (see https://docs.easybuild.io/en/latest/Writing_easyconfig_files.html#common-easyconfig-param-sources-git-config)
boegel
changed the title
boegel
changed the title
boegel
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is at least one software (avogadrolibs) that assumes that the directory
the repo is cloned into has a different name than the upstream repo.