edd_microdata_title filter span tags show in adjacent posts links in head #1142

Closed
will-b opened this Issue Apr 29, 2013 · 9 comments

Projects

None yet

3 participants

@will-b

span tags from edd_microdata_title filter on download single show up in the adjacent post links in the head ( <link rel='prev' title='<span....')

@pippinsplugins
Easy Digital Downloads member

Those are most likely being added incorrectly by your theme. Can you paste the contents of your header.php?

@will-b

Output in head
<link rel='prev' title='&lt;span itemprop=&quot;name&quot;&gt;Sample ....

Was using the Digital store theme, have not modified the header.
https://github.com/sksmatt/Digital-Store/blob/master/header.php

Checked Twenty Twelve, Eleven, same thing.

Seems like wordpress only escape the title

wp-includes/link-template.php:

$link = $previous ? "<link rel='prev' title='" : "<link rel='next' title='";
$link .= esc_attr( $title );
$link .= "' href='" . get_permalink($post) . "' />\n";
@pippinsplugins
Easy Digital Downloads member

Ah, look at that, you've just identified a WordPress core bug (I think). I'm digging into it further.

@pippinsplugins
Easy Digital Downloads member

I've submitted a core trac ticket on the issue: http://core.trac.wordpress.org/ticket/24232#ticket

@will-b

thanks, will keep an eye on it.

@pippinsplugins
Easy Digital Downloads member

Looks doubtful that core will get this taken care of anytime soon.

@will-b

Guess getting 3.6 ready is priority as its a bit behind schedule. Will check back in a couple of weeks. Thanks for the update.

@markjaquith
if ( ! did_action( 'wp_head' ) )
    return $title;
@pippinsplugins
Easy Digital Downloads member

Ah, of course, thanks @markjaquith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment