Skip to content

The EDD CSS files were too aggressively loaded #2098

Closed
wants to merge 2 commits into from

4 participants

@zackkatz
zackkatz commented Mar 5, 2014

The jQuery UI scripts in particular were being used throughout the admin and altering non-EDD page layouts.

@zackkatz zackkatz The EDD CSS files were too aggressively loaded
The jQuery UI scripts in particular were being used throughout the admin and altering non-EDD page layouts.
5b36292
@chriscct7
Easy Digital Downloads member

Hi there,
Thanks for the pull request 👍 . This indeed was a topic we wanted to revisit for 2.0.

You need to add a filter so extensions can also hook in. Alot of EDD extensions are built using those jQuery UI css files, and have pages that won't qualify as under the downloads post type or start using edd for the page names.

Also, this patch needs to be submitted to the release/2.0 or release/2.1, since we'll need to give some time for the affected extension authors to update their extensions to use the aforementioned filter.

I'm personally thinking 2.1 at the moment, but we'll discuss this later today and get back to you.

In the meantime, if you need to dequeue the UI files, you can use this: http://wordpress.org/support/topic/edd-is-loading-jquery-ui-css-on-non-edd-admin-pages?replies=4

@chriscct7 chriscct7 added this to the 2.0 milestone Mar 5, 2014
@chriscct7 chriscct7 self-assigned this Mar 5, 2014
@zackkatz zackkatz Add `edd_force_load_scripts` filter
Extensions can use `add_filter('edd_force_load_scripts',
'__return_true');` to have EDD scripts to load on their page.
31895b3
@zackkatz
zackkatz commented Mar 5, 2014

Hi Chris,
I've added the edd_force_load_scripts filter to override the page check. I wasn't sure what the name of the filter should be...

Let me know which version I should submit to. Thanks!

@coveralls

Coverage Status

Coverage remained the same when pulling 31895b3 on zackkatz:patch-1 into e57e274 on easydigitaldownloads:master.

@pippinsplugins
Easy Digital Downloads member

Another alternate method for this has been proposed here: #2077

@zackkatz
zackkatz commented Mar 6, 2014

Right, @pippinsplugins - I like #2077 better.

@zackkatz zackkatz closed this Mar 6, 2014
@pippinsplugins
Easy Digital Downloads member

Cool, so do I :)

@zackkatz zackkatz deleted the unknown repository branch Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.