A: satshop.fi + others (GDPR script) #13571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A generic for one domain? Is there more cases we cab add to this? |
peace2000
changed the title
peace2000
changed the title
|
Added more domains but also noticed I had to make changes as those sites store normal cookie related functions under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.satshop.fi/
Amasty GDPR script is used by some sites: https://publicwww.com/websites/%22Amasty_GdprFrontendUi%22/
But better make it specific instead of generic. I once added it as a generic #7051 but it was later removed (can't find it on ELC anymore), maybe it caused breakages as a generic filter.