New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asm, cglib and surefire for Java 10 support #211

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@ijuma
Contributor

ijuma commented Mar 21, 2018

ASM 6.1 adds support for Java 10:

https://mail.ow2.org/wws/arc/asm/2018-03/msg00000.html

Java 10 was released today.

@henri-tremblay

This comment has been minimized.

Contributor

henri-tremblay commented Mar 21, 2018

Thanks. The build seems unhappy because of TestNG. And issue with the encoding.

Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test: java.lang.NoSuchFieldError: ISO_8859_1
@henri-tremblay

This comment has been minimized.

Contributor

henri-tremblay commented Mar 21, 2018

Found it. surefire-testng should be upgraded to 2.21.0

@henri-tremblay henri-tremblay merged commit 2c0f509 into easymock:master Mar 21, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ijuma

This comment has been minimized.

Contributor

ijuma commented Mar 23, 2018

Thanks for fixing that. Is there a plan to release a new EasyMock version so that Java 10 is supported?

@henri-tremblay

This comment has been minimized.

Contributor

henri-tremblay commented Mar 26, 2018

Possibly this week. I would like to give a shot at auto-module as well in the same delivery.

@ijuma

This comment has been minimized.

Contributor

ijuma commented Mar 26, 2018

Thanks, sounds good.

@henri-tremblay henri-tremblay added this to the 3.6 milestone Apr 8, 2018

@henri-tremblay henri-tremblay changed the title from Update asm, cglib and surefire to Update asm, cglib and surefire for Java 10 support Apr 8, 2018

@ijuma

This comment has been minimized.

Contributor

ijuma commented Apr 9, 2018

Thanks for releasing 3.6. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment