Update to ASM 7.0 for full Java 11 support #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cglib also needs to be updated after a release containing cglib/cglib#138 is out.
|
It's sad you haven't told me that two days ago... And that the versions plugin doesn't work. |
henri-tremblay
approved these changes
Oct 28, 2018
|
It was only in Maven today so not sure how I could tell you two days ago. :) |
|
:-) Thanks for the PR anyway. I will deliver a new version quickly. I will just wait a bunch of days to make sure it stabilize :-) |
|
I suggest waiting for the cglib release too as that is needed for full Java 11 support without a system property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
cglib also needs to be updated after a release
containing cglib/cglib#138
is out.