Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ASM 7.0 for full Java 11 support #232

Merged
merged 1 commit into from Oct 28, 2018
Merged

Conversation

@ijuma
Copy link
Contributor

@ijuma ijuma commented Oct 27, 2018

cglib also needs to be updated after a release
containing cglib/cglib#138
is out.

cglib also needs to be updated after a release
containing cglib/cglib#138
is out.
@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Oct 27, 2018

@henri-tremblay
Copy link
Contributor

@henri-tremblay henri-tremblay commented Oct 28, 2018

It's sad you haven't told me that two days ago... And that the versions plugin doesn't work.

@henri-tremblay henri-tremblay merged commit 319767d into easymock:master Oct 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Oct 28, 2018

It was only in Maven today so not sure how I could tell you two days ago. :)

@henri-tremblay henri-tremblay added this to the 4.1 milestone Oct 28, 2018
@henri-tremblay henri-tremblay self-assigned this Oct 28, 2018
@henri-tremblay
Copy link
Contributor

@henri-tremblay henri-tremblay commented Oct 28, 2018

:-) Thanks for the PR anyway. I will deliver a new version quickly. I will just wait a bunch of days to make sure it stabilize :-)

@ijuma
Copy link
Contributor Author

@ijuma ijuma commented Oct 28, 2018

I suggest waiting for the cglib release too as that is needed for full Java 11 support without a system property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.