Fix core source-jar, added maven-source-plugin

[spelbergnl]

Hi, I noticed that the file easymock-4.3-sources.jar does not contain the sources for easymock itself. This merge request fixes this.

[henri-tremblay]

Are you sure about that? I think it does, but only during the deployBuild (see the profile at the end of the pom.xml)

[henri-tremblay]

It seems you are right. However, I still struggle to understand why.

[spelbergnl]

The problem is that the maven-source-plugin is only specified in the <pluginManagement> section but not in the <plugins> section.

[henri-tremblay]

No. Look at line 555 in the pom file

[spelbergnl]

You are right, in the deployBuild profile.

What probably happened is that the 4.3 release was not created using that profile. Would there be a way to fix it and release 4.3.1 with sources included?

Also, what would be a way to prevent this from happening again?

[henri-tremblay]

Good question. But I will investigate. And try to push the missing version. The same deployment process has been used for years without this issue. So I think Maven or the source plugin changed.