Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multibyte handling #60

Closed
wants to merge 1 commit into from

Conversation

mattn
Copy link

@mattn mattn commented Feb 21, 2013

multibyte characters shouldn't be treated length with strlen. it should be used with strdisplaywidth.
For example, is 3 bytes in utf-8, but 2 cells width. So it should use strdisplaywidth().

For example:

This should be:

But currently:

This change fix the issue.

@greduan
Copy link

greduan commented Feb 22, 2013

@Lokaltog I 👍 this. Awesome addition!

Although I don't experience this problem, I definitely love these kind of bug fixes. 😉

@lilydjwg
Copy link

Hi mattn, I'd like this bug to be fixed, but it dosen't work quite correct for me. Look the English words in the blue circles below:
bug

@mattn
Copy link
Author

mattn commented Mar 16, 2013

@lilydjwg What is value of ambiwidth ?

@lilydjwg
Copy link

@mattn double. And I can see some highlighting issues in your screenshot too. Maybe related to +conceal feature? My conceallevel=2 and concealcursor=nc in that window.

@mattn
Copy link
Author

mattn commented Mar 16, 2013

@lilydjwg I think my changes does not depend on the bug. Probably, it occur without my changes?

@lilydjwg
Copy link

@mattn Yes!

@mattn
Copy link
Author

mattn commented Mar 16, 2013

@lilydjwg Thank you, I guess you've better to file new issue. :)

@haya14busa
Copy link
Member

I included multibyte bug fix with some modifications and pushed to Lokaltog/vim-easymotion repository.

Thanks!

@haya14busa haya14busa closed this Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants