From f41bc406695f08964d39649fa4550d29bfe725da Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 26 Aug 2022 18:23:21 +0000 Subject: [PATCH 1/2] chore(deps): Update dependency compare-versions to v5 --- packages/brick-kit/package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/brick-kit/package.json b/packages/brick-kit/package.json index 228dd6a77a..aa558207eb 100644 --- a/packages/brick-kit/package.json +++ b/packages/brick-kit/package.json @@ -40,7 +40,7 @@ "@next-sdk/micro-app-sdk": "^2.1.1", "@next-sdk/user-service-sdk": "^2.1.1", "@ungap/event-target": "^0.2.3", - "compare-versions": "^4.1.4", + "compare-versions": "^5.0.1", "minimatch": "^3.1.2" }, "sideEffects": false, diff --git a/yarn.lock b/yarn.lock index 5a2214d09f..6449ee04e8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5755,10 +5755,10 @@ compare-func@^2.0.0: array-ify "^1.0.0" dot-prop "^5.1.0" -compare-versions@^4.1.4: - version "4.1.4" - resolved "https://registry.npmjs.org/compare-versions/-/compare-versions-4.1.4.tgz#3571f4d610924d4414846a4183d386c8f3d51112" - integrity sha512-FemMreK9xNyL8gQevsdRMrvO4lFCkQP7qbuktn1q8ndcNk1+0mz7lgE7b/sNvbhVgY4w6tMN1FDp6aADjqw2rw== +compare-versions@^5.0.1: + version "5.0.1" + resolved "https://registry.npmjs.org/compare-versions/-/compare-versions-5.0.1.tgz#14c6008436d994c3787aba38d4087fabe858555e" + integrity sha512-v8Au3l0b+Nwkp4G142JcgJFh1/TUhdxut7wzD1Nq1dyp5oa3tXaqb03EXOAB6jS4gMlalkjAUPZBMiAfKUixHQ== component-classes@^1.2.5: version "1.2.6" From ec35359f2cffe78c34031fa1e21a8da7d82e370b Mon Sep 17 00:00:00 2001 From: weareoutman Date: Tue, 11 Oct 2022 14:42:36 +0800 Subject: [PATCH 2/2] fix(): fix compare-versions usage --- packages/brick-kit/src/core/Runtime.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/brick-kit/src/core/Runtime.ts b/packages/brick-kit/src/core/Runtime.ts index 44fc046ea1..15b4fc95e8 100644 --- a/packages/brick-kit/src/core/Runtime.ts +++ b/packages/brick-kit/src/core/Runtime.ts @@ -15,7 +15,7 @@ import { SidebarMenu, RouteConf, } from "@next-core/brick-types"; -import compareVersions from "compare-versions"; +import { compare, type CompareOperator } from "compare-versions"; import { Kernel, MenuBar, @@ -198,10 +198,10 @@ export class Runtime implements AbstractRuntime { if (!matches) { throw new TypeError(`Invalid match version: ${matchVersion}`); } - return compareVersions.compare( + return compare( app.currentVersion, matches[2], - matches[1] as compareVersions.CompareOperator + matches[1] as CompareOperator ); } catch (error) { // eslint-disable-next-line no-console