Steve/auto remove dead if

.size-limit.js

@@ -53,7 +53,7 @@ module.exports = [
   },
   {
     path: "packages/brick-utils/dist/index.esm.js",
-    limit: "136 KB",
+    limit: "138 KB",
   },
   {
     path: "packages/editor-bricks-helper/dist/index.esm.js",

dll/editor-bricks-helper/manifest.snapshot.json

@@ -21,6 +21,7 @@
           "asyncProcessBrick",
           "asyncProcessStoryboard",
           "collectBricksByCustomTemplates",
+          "computeConstantCondition",
           "computeRealRoutePath",
           "convertValueByPrecision",
           "cook",
@@ -54,6 +55,8 @@
           "precookFunction",
           "preevaluate",
           "prefetchScript",
+          "removeDeadConditions",
+          "removeDeadConditionsInTpl",
           "resolveContextConcurrently",
           "restoreDynamicTemplates",
           "scanAppGetMenuInAny",

etc/brick-types.api.md

@@ -1844,6 +1844,8 @@ export interface RuntimeMisc {
 //
 // @internal (undocumented)
 export interface RuntimeStoryboard extends Storyboard {
+    // (undocumented)
+    $$deadConditionsRemoved?: boolean;
     // (undocumented)
     $$depsProcessed?: boolean;
     // (undocumented)

packages/brick-dll/manifest.snapshot.json

@@ -3506,6 +3506,7 @@
           "asyncProcessBrick",
           "asyncProcessStoryboard",
           "collectBricksByCustomTemplates",
+          "computeConstantCondition",
           "computeRealRoutePath",
           "convertValueByPrecision",
           "cook",
@@ -3539,6 +3540,8 @@
           "precookFunction",
           "preevaluate",
           "prefetchScript",
+          "removeDeadConditions",
+          "removeDeadConditionsInTpl",
           "resolveContextConcurrently",
           "restoreDynamicTemplates",
           "scanAppGetMenuInAny",

packages/brick-kit/src/checkIf.ts

@@ -17,7 +17,7 @@ export interface IfContainer {
    *
    * ```yaml
    * - brick: your.any-brick
-   *   if: '<% FLAGS['your-feature-flag'] %>'
+   *   if: '<% FLAGS["your-feature-flag"] %>'
    * ```
    */
   if?: unknown;

packages/brick-kit/src/core/CustomTemplates/registerCustomTemplate.ts

@@ -1,10 +1,13 @@
 import { CustomTemplateConstructor } from "@next-core/brick-types";
+import { removeDeadConditionsInTpl } from "@next-core/brick-utils";
+import { getRuntime } from "../../runtime";
 import { appRegistered, customTemplateRegistry } from "./constants";
 
 export function registerCustomTemplate(
   tplName: string,
   tplConstructor: CustomTemplateConstructor,
-  appId?: string
+  appId?: string,
+  deadCOnditionsRemoved?: boolean
 ): void {
   let tagName = tplName;
   // When a template is registered by an app, its namespace maybe missed.
@@ -29,6 +32,12 @@ export function registerCustomTemplate(
       );
     }
   }
+  if (!deadCOnditionsRemoved && process.env.NODE_ENV !== "test") {
+    removeDeadConditionsInTpl(tplConstructor, {
+      constantFeatureFlags: true,
+      featureFlags: getRuntime().getFeatureFlags(),
+    });
+  }
   // Now we allow re-register custom template
   customTemplateRegistry.set(tagName, {
     ...tplConstructor,

packages/brick-kit/src/core/Kernel.spec.ts

@@ -277,7 +277,8 @@ describe("Kernel", () => {
         proxy: {},
         bricks: [],
       },
-      "app-a"
+      "app-a",
+      true
     );
 
     spyOnLoadScript.mockClear();

packages/brick-kit/src/core/Kernel.ts

@@ -641,7 +641,8 @@ export class Kernel {
               proxy: tpl.proxy,
               state: tpl.state,
             },
-            storyboard.app?.id
+            storyboard.app?.id,
+            true
           );
         }
       }

packages/brick-kit/src/core/Router.spec.ts

@@ -32,7 +32,10 @@ jest.mock("../auth");
 jest.mock("../themeAndMode");
 jest.mock("../runtime");
 jest.mock("../internal/checkPermissions");
-jest.mock("../internal/getStandaloneInstalledApps");
+jest.mock("../internal/getStandaloneInstalledApps", () => ({
+  getStandaloneInstalledApps: jest.fn().mockReturnValue([]),
+  preFetchStandaloneInstalledApps: jest.fn().mockResolvedValue(undefined),
+}));
 jest.mock("@next-core/easyops-analytics", () => ({
   apiAnalyzer: {
     create: () => jest.mock,

packages/brick-kit/src/core/Router.ts

@@ -13,7 +13,9 @@ import {
   scanStoryboard,
   mapCustomApisToNameAndNamespace,
   CustomApiInfo,
+  removeDeadConditions,
 } from "@next-core/brick-utils";
+import { HttpResponseError } from "@next-core/brick-http";
 import { apiAnalyzer, userAnalytics } from "@next-core/easyops-analytics";
 import {
   LocationContext,
@@ -48,7 +50,6 @@ import { preCheckPermissions } from "../internal/checkPermissions";
 import { clearPollTimeout } from "../internal/poll";
 import { shouldBeDefaultCollapsed } from "../internal/shouldBeDefaultCollapsed";
 import { registerStoryboardFunctions } from "./StoryboardFunctions";
-import { HttpResponseError } from "@next-core/brick-http";
 import { registerMock } from "./MockRegistry";
 import { registerFormRenderer } from "./CustomForms/registerFormRenderer";
 import {
@@ -252,22 +253,35 @@ export class Router {
     if (storyboard) {
       await this.kernel.fulfilStoryboard(storyboard);
 
+      removeDeadConditions(storyboard, {
+        constantFeatureFlags: true,
+        featureFlags: this.featureFlags,
+      });
+
       // 将动态解析后的模板还原，以便重新动态解析。
       restoreDynamicTemplates(storyboard);
 
+      const parallelRequests: Promise<unknown>[] = [];
+
       // 预加载权限信息
       if (isLoggedIn() && !getAuth().isAdmin) {
-        await preCheckPermissions(storyboard);
+        parallelRequests.push(preCheckPermissions(storyboard));
       }
 
       // Standalone App 需要额外读取 Installed App 信息
       if (window.STANDALONE_MICRO_APPS && !window.NO_AUTH_GUARD) {
         // TODO: get standalone apps when NO_AUTH_GUARD, maybe from conf.yaml
-        await preFetchStandaloneInstalledApps(storyboard);
-        this.kernel.bootstrapData.offSiteStandaloneApps =
-          getStandaloneInstalledApps();
+        parallelRequests.push(
+          preFetchStandaloneInstalledApps(storyboard).then(() => {
+            this.kernel.bootstrapData.offSiteStandaloneApps =
+              getStandaloneInstalledApps();
+          })
+        );
       }
 
+      // `loadDepsOfStoryboard()` may requires these data.
+      await Promise.all(parallelRequests);
+
       // 如果找到匹配的 storyboard，那么根据路由匹配得到的 sub-storyboard 加载它的依赖库。
       const subStoryboard =
         this.locationContext.getSubStoryboardByRoute(storyboard);

packages/brick-types/src/manifest.ts

@@ -295,6 +295,7 @@ export interface RuntimeStoryboard extends Storyboard {
   $$fulfilled?: boolean;
   $$fulfilling?: Promise<void>;
   $$i18nFulfilled?: boolean;
+  $$deadConditionsRemoved?: boolean;
 }
 
 export function isRouteConfOfBricks(

packages/brick-utils/src/index.ts

@@ -31,3 +31,4 @@ export * from "./visitStoryboard";
 export * from "./debounceByAnimationFrame";
 export * from "./scanInstalledAppsInStoryboard";
 export * from "./makeThrottledAggregation";
+export * from "./removeDeadConditions";