Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在js方法ModalTrigger.prototype.showk中有个bug #10

Closed
remind opened this issue Feb 15, 2015 · 0 comments

Comments

@remind
Copy link

commented Feb 15, 2015

     $modal.toggleClass('fade', options.fade)
            .addClass(options.cssClass)
            .toggleClass('modal-md', options.size === 'md')
            .toggleClass('modal-sm', options.size === 'sm')
            .toggleClass('modal-lg', options.size === 'lg')
            .toggleClass('modal-fullscreen', options.size === 'fullscreen')
            .toggleClass('modal-loading', !this.isShown);

这里的modal-md,modal-sm,modal-lg,modal-fullscreen,modal-loading应该要加到$dialog上才会有作用,否则在使用lg时样式会乱

    $modal.toggleClass('fade', options.fade)
        .addClass(options.cssClass);

    $dialog.toggleClass('modal-md', options.size === 'md')
        .toggleClass('modal-sm', options.size === 'sm')
        .toggleClass('modal-lg', options.size === 'lg')
        .toggleClass('modal-fullscreen', options.size === 'fullscreen')
        .toggleClass('modal-loading', !this.isShown);

@catouse catouse added the bug label Feb 16, 2015

catouse added a commit that referenced this issue Jan 25, 2016

@catouse catouse closed this Jan 25, 2016

catouse added a commit that referenced this issue Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.