From 09ac4de5f70d07c5df56bdf9914359d32e995527 Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Tue, 10 Mar 2026 13:02:04 +0200 Subject: [PATCH 1/4] fix tests --- tests/testthat/test-effectsize.R | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/testthat/test-effectsize.R b/tests/testthat/test-effectsize.R index ad2cd85a..1ec34d18 100644 --- a/tests/testthat/test-effectsize.R +++ b/tests/testthat/test-effectsize.R @@ -390,12 +390,13 @@ test_that("htest | rank", { expect_equal(rank_epsilon_squared(kt)[[1]], E, ignore_attr = TRUE) }) -test_that("htest | Get args from htest", { +test_that("htest | Get args from htest (t.test)", { + skip_on_cran() # TODO: remove this after next R version release (4.6) tt <- t.test( mtcars$hp, mtcars$mpg, alternative = "l", - mu = -3, + mu = 100, conf.level = 0.8, var.equal = TRUE ) @@ -405,18 +406,21 @@ test_that("htest | Get args from htest", { mtcars$hp, mtcars$mpg, alternative = "l", - mu = -3, + mu = 100, ci = 0.8 ), ignore_attr = TRUE ) +}) +test_that("htest | Get args from htest (wilcox.test)", { + skip_on_cran() # TODO: remove this after next R version release (4.6) suppressWarnings({ - ww1 <- wilcox.test(mtcars$hp, mtcars$mpg, alternative = "l", mu = -3) + ww1 <- wilcox.test(mtcars$hp, mtcars$mpg, alternative = "l", mu = 80) }) expect_equal( rank_biserial(ww1), - rank_biserial(mtcars$hp, mtcars$mpg, alternative = "l", mu = -3), + rank_biserial(mtcars$hp, mtcars$mpg, alternative = "l", mu = 80), ignore_attr = TRUE ) @@ -425,7 +429,7 @@ test_that("htest | Get args from htest", { mtcars$hp, mtcars$mpg, alternative = "l", - mu = -3, + mu = 80, conf.int = TRUE, conf.level = 0.8 ) @@ -436,7 +440,7 @@ test_that("htest | Get args from htest", { mtcars$hp, mtcars$mpg, alternative = "l", - mu = -3, + mu = 80, ci = 0.8 ), ignore_attr = TRUE From 1f82c85ac6789bf41190403f6d6ea92e0e3565c5 Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Tue, 10 Mar 2026 13:31:43 +0200 Subject: [PATCH 2/4] version bump --- DESCRIPTION | 2 +- NEWS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 7431d1ab..66a083d6 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: effectsize Title: Indices of Effect Size -Version: 1.0.1.2 +Version: 1.0.2 Authors@R: c(person(given = "Mattan S.", family = "Ben-Shachar", diff --git a/NEWS.md b/NEWS.md index 1cee7b83..efd09c2d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# effectsize 1.0.x +# effectsize 1.0.2 ## New features From a97673bfd5cac261afe1a5045d859eb311e0259f Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Tue, 10 Mar 2026 14:18:41 +0200 Subject: [PATCH 3/4] fix tests on dev --- tests/testthat/test-effectsize.R | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/testthat/test-effectsize.R b/tests/testthat/test-effectsize.R index 1ec34d18..5883de19 100644 --- a/tests/testthat/test-effectsize.R +++ b/tests/testthat/test-effectsize.R @@ -391,7 +391,6 @@ test_that("htest | rank", { }) test_that("htest | Get args from htest (t.test)", { - skip_on_cran() # TODO: remove this after next R version release (4.6) tt <- t.test( mtcars$hp, mtcars$mpg, @@ -414,7 +413,6 @@ test_that("htest | Get args from htest (t.test)", { }) test_that("htest | Get args from htest (wilcox.test)", { - skip_on_cran() # TODO: remove this after next R version release (4.6) suppressWarnings({ ww1 <- wilcox.test(mtcars$hp, mtcars$mpg, alternative = "l", mu = 80) }) @@ -431,7 +429,7 @@ test_that("htest | Get args from htest (wilcox.test)", { alternative = "l", mu = 80, conf.int = TRUE, - conf.level = 0.8 + conf.level = 0.7 ) }) expect_equal( @@ -441,9 +439,10 @@ test_that("htest | Get args from htest (wilcox.test)", { mtcars$mpg, alternative = "l", mu = 80, - ci = 0.8 + ci = 0.7 ), - ignore_attr = TRUE + ignore_attr = TRUE, + tolerance = 0.01 ) }) From 71dba21d119a62ca0531c2f12795d2de3452d85f Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Tue, 10 Mar 2026 21:57:18 +0200 Subject: [PATCH 4/4] Update cran-comments.md --- cran-comments.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 81166161..9d4b39a9 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,7 +1,7 @@ ## Test environments -* local installation: R 4.4.1 on Windows 11 x64 +* local installation: R 4.5.2 on Windows 11 x64 * GitHub Actions - Windows: release, devel - macOS: release @@ -16,7 +16,6 @@ ## revdepcheck results -We checked 28 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. - - * We saw 0 new problems related to effectsize. +We checked 37 reverse dependencies (34 from CRAN + 3 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. +* We saw 0 new problems related to effectsize.