Skip to content

Conversation

@strengejacke
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the parameters package by integrating equivalence_test() functionality with key output objects from the modelbased package. This allows users to perform equivalence tests directly on estimated means, contrasts, and slopes, streamlining statistical workflows. Additionally, the update includes a minor version bump and minor documentation improvements for example code blocks.

Highlights

  • Extended Equivalence Testing: The equivalence_test() function now supports objects generated by the modelbased package, specifically estimate_means, estimate_contrasts, and estimate_slopes, enhancing interoperability.
  • Improved ROPE Range Handling: The internal .check_rope_range function has been updated to correctly extract the underlying model from modelbased-objects to define the Region of Practical Equivalence (ROPE).
  • Documentation and Version Updates: The package version has been incremented to 0.28.2.2, RoxygenNote updated, and minor cleanups were applied to example code in several documentation files for better R version compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for equivalence_test() for objects from the modelbased package, specifically for estimate_means, estimate_contrasts, and estimate_slopes classes. This is achieved by aliasing the existing equivalence_test.lm method and adding special handling within the .check_rope_range() helper function to correctly determine the ROPE range from the underlying model. The implementation is sound. I have one suggestion to improve user feedback when the underlying model cannot be extracted. The pull request also includes documentation updates across many files, which appear to be related to a roxygen2 version update and are consistent.

@strengejacke strengejacke merged commit 7cd9d0f into main Sep 25, 2025
17 of 20 checks passed
@strengejacke strengejacke deleted the equitest_modelbased branch September 25, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants