New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow local currency #325
Conversation
1b6ddc1
to
934665e
Compare
* @param string $currency Possible currencies: BRL | ||
* @return boolean Return true if EBANX process the currency | ||
*/ | ||
public function ebanx_process_merchant_currency($currency) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method defined 3 times in similar classes, can't it be moved to the abstract class-wc-ebanx-gateway.php class?
e531c5b
to
b116e10
Compare
@@ -14,5 +14,5 @@ | |||
?> | |||
|
|||
<div class="woocommerce-message"> | |||
<span><?php printf( wp_kses( __( 'Payment successfully made using %1$s oxxo in %2$s.', 'woocommerce-gateway-ebanx' ), array( 'strong' => array() ) ), '' ); ?></span> | |||
<span><?php _e('Payment successfully made using Servipag.', 'woocommerce-gateway-ebanx' ); ?></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the simplified translation call. Is it part of this pull request or a quality one? Could this pull request be also considered a quality one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so... because these changes are a bunch of fixes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet
Fixes #317