Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow local currency #325

Merged
merged 7 commits into from Feb 23, 2017
Merged

Conversation

cezarsmpio
Copy link
Contributor

@cezarsmpio cezarsmpio commented Feb 23, 2017

Fixes #317

* @param string $currency Possible currencies: BRL
* @return boolean Return true if EBANX process the currency
*/
public function ebanx_process_merchant_currency($currency) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method defined 3 times in similar classes, can't it be moved to the abstract class-wc-ebanx-gateway.php class?

@@ -14,5 +14,5 @@
?>

<div class="woocommerce-message">
<span><?php printf( wp_kses( __( 'Payment successfully made using %1$s oxxo in %2$s.', 'woocommerce-gateway-ebanx' ), array( 'strong' => array() ) ), '' ); ?></span>
<span><?php _e('Payment successfully made using Servipag.', 'woocommerce-gateway-ebanx' ); ?></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the simplified translation call. Is it part of this pull request or a quality one? Could this pull request be also considered a quality one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so... because these changes are a bunch of fixes ;)

Copy link
Contributor

@SparK-Cruz SparK-Cruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gpressutto5 gpressutto5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@cezarsmpio cezarsmpio merged commit 2812ec5 into develop Feb 23, 2017
@cezarsmpio cezarsmpio deleted the feature/allow-local-currency branch March 1, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants