Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification conflicts #509

Merged
merged 5 commits into from May 26, 2017
Merged

Notification conflicts #509

merged 5 commits into from May 26, 2017

Conversation

cezarsmpio
Copy link
Contributor

No description provided.

@cezarsmpio cezarsmpio added this to the Sprint #9 milestone May 24, 2017
@cezarsmpio cezarsmpio self-assigned this May 24, 2017
@@ -9,7 +9,7 @@ services:
ports:
- 3306:3306
volumes:
- ./.data:/var/lib/mysql
- ./.data/db:/var/lib/mysql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind to explain?

Copy link
Contributor

@SparK-Cruz SparK-Cruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'OP' => 'Opened'
);

$order->add_order_note(sprintf(__('EBANX: The payment has been updated to: %s.', 'woocommerce-gateway-ebanx'), $status[$data->payment->status]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it be confusing? The merchant will get a order status and a payment status at the same time. And sometimes it is not needed, like when the payment was confirmed, woocommerce already tells the merchant it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing is the order status and another is the payment status. This merchant specifically there's a problem that I related to you recently and that envolves pay. The notes have had various updated and generate two shipments of the same product and we couldn't identify where the error was. So, adding this new order with our prefix EBANX it will be when the payment was updated. Do you agree?

@cezarsmpio cezarsmpio merged commit e9740d3 into develop May 26, 2017
@gpressutto5 gpressutto5 deleted the bugfix/notification branch July 20, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants