New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification conflicts #509
Conversation
…BANX payment notification issues
@@ -9,7 +9,7 @@ services: | |||
ports: | |||
- 3306:3306 | |||
volumes: | |||
- ./.data:/var/lib/mysql | |||
- ./.data/db:/var/lib/mysql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind to explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
'OP' => 'Opened' | ||
); | ||
|
||
$order->add_order_note(sprintf(__('EBANX: The payment has been updated to: %s.', 'woocommerce-gateway-ebanx'), $status[$data->payment->status])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't it be confusing? The merchant will get a order status and a payment status at the same time. And sometimes it is not needed, like when the payment was confirmed, woocommerce already tells the merchant it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing is the order status and another is the payment status. This merchant specifically there's a problem that I related to you recently and that envolves pay. The notes have had various updated and generate two shipments of the same product and we couldn't identify where the error was. So, adding this new order with our prefix EBANX
it will be when the payment was updated. Do you agree?
c6f274a
to
1ef4210
Compare
No description provided.