Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: DDL process comment change correctly & drop references when index is dropped #1109

Merged
merged 1 commit into from Sep 1, 2017

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented Aug 31, 2017

Changes were not applied correctly and subsequent calls will produce new versions.

How to reproduce:

    assertThat(migration.generateMigration()).isEqualTo("1.1");
    assertThat(migration.generateMigration()).isNull(); // subsequent call fails

(I will add a the test cases later)

Also added a class "DdlHelp" where I want to put various static utility functions. Good idea? Good name?

@rbygrave rbygrave added the bug label Sep 1, 2017
@rbygrave rbygrave added this to the 10.4.4 milestone Sep 1, 2017
@rbygrave rbygrave merged commit f2e8b65 into ebean-orm:master Sep 1, 2017
@rPraml rPraml deleted the fix/ddl-process-comments branch March 1, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants