Skip to content

Conversation

@reva
Copy link
Contributor

@reva reva commented Mar 5, 2021

The OrderType is actually not a fixed set but has bank specific codes as well. e.g. Credit Suisse in Switzerland has XTD for their test environment. There even seems to be some standardisation around Switzerland specific codes: https://www.six-group.com/dam/download/banking-services/interbank-clearing/en/standardization/ebics/ebics.pdf.

I suggest opening up the 'OrderType' to be able to set any order code in the future. This change should be completely backwards compatible.

@uwemaurer
Copy link
Collaborator

I like this change to open up this enum! I found a few places which call .toString() on the OrderType (now EbicsOrderType)

eg lines like orderType = EbicsXmlFactory.createOrderType(type.toString()); need to be changed to orderType = EbicsXmlFactory.createOrderType(type.getCode());

@reva reva force-pushed the feature/order-type-interface branch from 9b3cdc6 to 485da41 Compare March 5, 2021 17:33
@reva
Copy link
Contributor Author

reva commented Mar 5, 2021

@uwemaurer Thanks for the quick feedback! Should be fixed now. Is there a release process for this library?

@uwemaurer uwemaurer merged commit 3b0a97a into ebics-java:master Mar 20, 2021
@uwemaurer
Copy link
Collaborator

Thank you for your change. There is currently no release process. I suggest to use a version built on JitPack with a specific commit. Having proper releases would be good, I am planning to do this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants