Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with multiple identical communities with addCommunity #27

Closed
sje30 opened this issue Apr 14, 2020 · 3 comments
Closed

Issue with multiple identical communities with addCommunity #27

sje30 opened this issue Apr 14, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sje30
Copy link
Contributor

sje30 commented Apr 14, 2020

If I run this code several times, I end up with multiple copies of the same community lodged in the record. Is this intentional?

deposit_draft$setCommunities(communities = c("codecheck"))

Should it only add the community if it is not already in self$metadata$communities ?

By contrast, running other lines multiple times does not have this effect (e.g. setTitle())

@eblondel eblondel self-assigned this Apr 14, 2020
@eblondel eblondel added the bug Something isn't working label Apr 14, 2020
@eblondel eblondel added this to the 0.3 milestone Apr 14, 2020
@eblondel
Copy link
Owner

thanks @sje30, look at it ASAP.

eblondel added a commit that referenced this issue Apr 14, 2020
@eblondel
Copy link
Owner

Fixed! let me know

@sje30
Copy link
Contributor Author

sje30 commented Apr 14, 2020

Thanks, yes, it seems to not duplicate now. Wonderful, thank you for being so responsive.

@sje30 sje30 closed this as completed Apr 14, 2020
@eblondel eblondel changed the title multiple identical communities Issue with multiple identical communities with addCommunity Apr 14, 2020
@eblondel eblondel modified the milestones: 0.3, 0.4 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants