Skip to content

/ zen4R

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDepositions returns always 10 records #5

Closed
eblondel opened this issue Jun 10, 2019 · 1 comment
Closed

getDepositions returns always 10 records #5

eblondel opened this issue Jun 10, 2019 · 1 comment
Assignees
@eblondel
Labels
bug
Projects
zen4R summer 2019 project
Milestone
0.2

Comments

@eblondel
Copy link
Owner

@eblondel eblondel commented Jun 10, 2019

Needs size and page parameters with iteration
@eblondel eblondel added the bug label Jun 10, 2019
@eblondel eblondel self-assigned this Jun 10, 2019
eblondel added a commit that referenced this issue Jun 10, 2019
@eblondel
#5 iterate to get all depositions, size param added for flexibility
Loading status checks…
be71d0e
eblondel added a commit that referenced this issue Jun 10, 2019
@eblondel
#4 fix deleteRecords to align on #5 fix
Loading status checks…
c93a687
@eblondel eblondel modified the milestones: 0.2, 0.1 Jun 11, 2019
@eblondel
Copy link
Owner Author

@eblondel eblondel commented Jun 11, 2019

This has been fixed, now the getDepositions is doing a call by page until it get all records. An parameter size is added to getDepositions function with default value to 10, matching the default size number handled by Zenodo API (Elasticsearch).
@eblondel eblondel closed this Jun 11, 2019
@eblondel eblondel mentioned this issue Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eblondel eblondel

Labels
bug
Projects
zen4R summer 2019 project
  
Done
Milestone
0.2
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@eblondel
You can’t perform that action at this time.