Add some pretty questionable logic to include old transaction in email

Make it easier to catch accidental screwups
ebroder · Jul 14, 2013 · d0a1867 · d0a1867
1 parent 9879f32
commit d0a1867
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/bluechips/controllers/spend.py b/bluechips/controllers/spend.py
@@ -100,10 +100,18 @@ def update(self, id=None):
             e = model.Expenditure()
             meta.Session.add(e)
             op = 'created'
+
+            old_expenditure = None
         else:
             e = meta.Session.query(model.Expenditure).get(id)
             if e is None:
                 abort(404)
+
+            old_expenditure = render('/emails/expenditure.txt',
+                                     extra_vars={'expenditure': e,
+                                                 'op': 'previously',
+                                                 'old_expenditure': None})
+
             # If a user gets removed from a transaction, they should
             # still get an email
             involved_users.update(sp.user for sp in e.splits if sp.share != 0)
@@ -132,7 +140,8 @@ def update(self, id=None):
         involved_users.add(e.spender)
         body = render('/emails/expenditure.txt',
                       extra_vars={'expenditure': e,
-                                  'op': op})
+                                  'op': op,
+                                  'old_expenditure': old_expenditure})
         g.handle_notification(involved_users, show, body)
 
         return h.redirect_to('/')

diff --git a/bluechips/templates/emails/expenditure.txt b/bluechips/templates/emails/expenditure.txt
@@ -10,5 +10,9 @@ The shares of this expenditure are:
 ${split.user|n,unicode}: ${split.share|n,unicode}
 % endfor
 
+% if old_expenditure is not None:
+${old_expenditure}
+% else
 To view or edit this expenditure, visit:
 ${h.url_for(controller='spend', action='edit', id=expenditure.id, qualified=True)}
+% endif