Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External CSS isn't imported correctly #122

Closed
t4t5 opened this issue Mar 8, 2016 · 7 comments
Closed

External CSS isn't imported correctly #122

t4t5 opened this issue Mar 8, 2016 · 7 comments

Comments

@t4t5
Copy link

t4t5 commented Mar 8, 2016

Opening a new issue for the discussion at #121.

Since upgrading Ember CLI, the addon doesn't correctly import CSS-files that are referenced in the ember-cli-build.js-file.

app.import('bower_components/sweetalert/dist/sweetalert.css');

...never makes it into vendor.css for example. Same with the CSS in some addons like ivy-codemirror.

Strangely, this addon's CSS seems to get imported just fine.

Haven't tracked down the error yet, but any help is appreciated! :)

@t4t5
Copy link
Author

t4t5 commented Mar 8, 2016

Update: downgrading to Ember CLI 2.3.0 fixes the problem. Hmm.

@ankushdharkar
Copy link
Contributor

+1

May have something to do with these changes in 2.4.0: ember-cli/ember-cli#5545

I am using an ember-cli-sass preprocessor. This is the error I get on running ember server:

version: 2.4.0
this.vendorStaticStyles.concat is not a function
TypeError: this.vendorStaticStyles.concat is not a function
    at EmberApp.styles (<Project-Destination>/node_modules/ember-component-css/index.js:85:43)
    at EmberApp.toArray (<Project-Destination>/node_modules/ember-cli/lib/broccoli/ember-app.js:1493:10)
    at EmberApp.toTree (<Project-Destination>/node_modules/ember-cli/lib/broccoli/ember-app.js:1514:30)
    at module.exports (<Project-Destination>/ember-cli-build.js:144:14)
    at Class.module.exports.Task.extend.setupBroccoliBuilder (<Project-Destination>/node_modules/ember-cli/lib/models/builder.js:55:19)
    at Class.module.exports.Task.extend.init (<Project-Destination>/node_modules/ember-cli/lib/models/builder.js:89:10)
    at new Class (<Project-Destination>/node_modules/core-object/core-object.js:18:12)
    at Class.module.exports.Task.extend.run (<Project-Destination>/node_modules/ember-cli/lib/tasks/serve.js:15:19)
    at <Project-Destination>/node_modules/ember-cli/lib/commands/serve.js:70:22
    at lib$rsvp$$internal$$tryCatch (<Project-Destination>/node_modules/rsvp/dist/rsvp.js:493:16)

@jakedetels
Copy link

We're having the same issue. We'll have to stop using this add-on until the issue is resolved.

@webark
Copy link
Owner

webark commented Mar 10, 2016

@jakedetels we are in the process of fixing this issue with the referenced PR. Hoping to have it merged soon so it will work with the most recent and future versions of ember-cli. Please follow along there. Don't loose ❤️ ! :)

@simonihmig
Copy link

Same here. Styles from ember-gestures that are just placed in addon/styles/app.css do land in vendor.css, but it seems everything explicitly imported (using app.import()) not!

Stop using this addon is not an option with a whole lot of compontents implementd and launching the app today! Will have to revert to ember-cli 2.3.0...

@ebryn
Copy link
Collaborator

ebryn commented Mar 22, 2016

Please give our newly released 0.2.0-beta.1 release a shot and let us know if that solves this issue for you.

@webark
Copy link
Owner

webark commented Mar 25, 2016

The beta version should solve this. Please reopen with an example if it does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants