From 43ed0a422e45a71f3462b20eae24325b7895d0f8 Mon Sep 17 00:00:00 2001
From: planctus <davidepuntoferrante@gmail.com>
Date: Tue, 7 Jun 2022 09:40:49 +0300
Subject: [PATCH] feat(news-ticker): Adding support for external links -
 FRONT-2653 (#2559)

---
 .../__snapshots__/news-ticker.test.js.snap    | 51 ++++++++++++++++---
 .../news-ticker/news-ticker.html.twig         |  3 ++
 src/specs/components/news-ticker/demo/data.js |  1 +
 3 files changed, 49 insertions(+), 6 deletions(-)

diff --git a/src/implementations/twig/components/news-ticker/__snapshots__/news-ticker.test.js.snap b/src/implementations/twig/components/news-ticker/__snapshots__/news-ticker.test.js.snap
index 91ec2b24edf..1ae44925b80 100644
--- a/src/implementations/twig/components/news-ticker/__snapshots__/news-ticker.test.js.snap
+++ b/src/implementations/twig/components/news-ticker/__snapshots__/news-ticker.test.js.snap
@@ -34,11 +34,24 @@ exports[`News ticker Default renders correctly 1`] = `
             class="ecl-news-ticker__slide"
           >
             <a
-              class="ecl-link ecl-news-ticker__slide-text"
+              class="ecl-link ecl-link--icon ecl-link--icon-after ecl-news-ticker__slide-text"
               href="/example"
               tabindex="-1"
             >
-              Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat
+              <span
+                class="ecl-link__label"
+              >
+                Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat
+              </span>
+              <svg
+                aria-hidden="true"
+                class="ecl-icon ecl-icon--2xs ecl-link__icon"
+                focusable="false"
+              >
+                <use
+                  xlink:href="/icons.svg#external"
+                />
+              </svg>
             </a>
           </li>
           <li
@@ -234,11 +247,24 @@ exports[`News ticker Default renders correctly with extra attributes 1`] = `
             class="ecl-news-ticker__slide"
           >
             <a
-              class="ecl-link ecl-news-ticker__slide-text"
+              class="ecl-link ecl-link--icon ecl-link--icon-after ecl-news-ticker__slide-text"
               href="/example"
               tabindex="-1"
             >
-              Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat
+              <span
+                class="ecl-link__label"
+              >
+                Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat
+              </span>
+              <svg
+                aria-hidden="true"
+                class="ecl-icon ecl-icon--2xs ecl-link__icon"
+                focusable="false"
+              >
+                <use
+                  xlink:href="/icons.svg#external"
+                />
+              </svg>
             </a>
           </li>
           <li
@@ -432,11 +458,24 @@ exports[`News ticker Default renders correctly with extra class names 1`] = `
             class="ecl-news-ticker__slide"
           >
             <a
-              class="ecl-link ecl-news-ticker__slide-text"
+              class="ecl-link ecl-link--icon ecl-link--icon-after ecl-news-ticker__slide-text"
               href="/example"
               tabindex="-1"
             >
-              Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat
+              <span
+                class="ecl-link__label"
+              >
+                Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat
+              </span>
+              <svg
+                aria-hidden="true"
+                class="ecl-icon ecl-icon--2xs ecl-link__icon"
+                focusable="false"
+              >
+                <use
+                  xlink:href="/icons.svg#external"
+                />
+              </svg>
             </a>
           </li>
           <li
diff --git a/src/implementations/twig/components/news-ticker/news-ticker.html.twig b/src/implementations/twig/components/news-ticker/news-ticker.html.twig
index 2f82435379d..cbe5f8afd5e 100644
--- a/src/implementations/twig/components/news-ticker/news-ticker.html.twig
+++ b/src/implementations/twig/components/news-ticker/news-ticker.html.twig
@@ -7,6 +7,7 @@
         {
           "content" (string)
           "link" (string)
+          "external" (boolean)
         },
         ...
       ]
@@ -75,6 +76,8 @@
             link: {
               label: _item.content,
               path: _item.link,
+              external: _item.external,
+              icon_path: icon_path,
             },
             extra_classes: 'ecl-news-ticker__slide-text',
             extra_attributes: [
diff --git a/src/specs/components/news-ticker/demo/data.js b/src/specs/components/news-ticker/demo/data.js
index f39da127639..95c36ea6dd2 100644
--- a/src/specs/components/news-ticker/demo/data.js
+++ b/src/specs/components/news-ticker/demo/data.js
@@ -15,6 +15,7 @@ module.exports = {
       content:
         'Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat',
       link: exampleLink,
+      external: true,
     },
     {
       content: