Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main-policy-hub): add content type - INNO-1879 #1384

Merged
merged 12 commits into from Nov 8, 2019

Conversation

@emeryro
Copy link
Contributor

emeryro commented Oct 29, 2019

PR description

Specs are on the ticket

Notes:

  • current implementation of horizontal description list do not allow extra horizontal padding when used in a 6 large column (width are enforced). So it is currently not possible to display the first "box" exactly as on the screenshots
  • social media follow links have been displayed using the dedicated component (as it weredone on other content types). So display is not the same as on the screenshots.

Also, border utilities had to be updated to allow breakpoint based fine tuning

@HAL-Patch-INNO

This comment has been minimized.

Copy link
Contributor

HAL-Patch-INNO commented Oct 29, 2019

Deploy preview for europa-component-library ready!

Built with commit 76ad334

https://deploy-preview-1384--europa-component-library.netlify.com

emeryro added 3 commits Oct 29, 2019
@emeryro emeryro marked this pull request as ready for review Oct 30, 2019
@emeryro emeryro requested a review from ec-europa/inno as a code owner Oct 30, 2019
@emeryro emeryro removed their assignment Oct 30, 2019
emeryro and others added 7 commits Nov 3, 2019
@yhuard
yhuard approved these changes Nov 8, 2019
@yhuard yhuard removed their assignment Nov 8, 2019
@yhuard yhuard merged commit 8f37d83 into v2-dev Nov 8, 2019
3 checks passed
3 checks passed
Semantic Pull Request ready to be squashed
Details
continuous-integration/drone/push the build was successful
Details
drone/netlify Preview ready!
Details
@yhuard yhuard deleted the feat/ct-main-policy-hub-INNO-1879 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.