Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fact and figures): add component - INNO-1927 #1391

Merged
merged 11 commits into from Nov 7, 2019

Conversation

@emeryro
Copy link
Contributor

emeryro commented Oct 31, 2019

emeryro added 2 commits Oct 31, 2019
@emeryro emeryro marked this pull request as ready for review Nov 4, 2019
@emeryro emeryro requested a review from ec-europa/inno as a code owner Nov 4, 2019
@emeryro emeryro removed their assignment Nov 4, 2019
@yhuard yhuard self-assigned this Nov 4, 2019
Copy link
Contributor

yhuard left a comment

overall, it looks good but it "breaks" when you activate the #test-fake-global-rules ;-)

@yhuard yhuard removed their assignment Nov 4, 2019
emeryro added 4 commits Nov 5, 2019
Copy link
Contributor

yhuard left a comment

"View all metrics" is still affected by #test-fake-global-rules:/

emeryro added 2 commits Nov 7, 2019
@yhuard
yhuard approved these changes Nov 7, 2019
@yhuard yhuard merged commit c0f37a9 into v2-dev Nov 7, 2019
3 checks passed
3 checks passed
Semantic Pull Request ready to be squashed
Details
continuous-integration/drone/push the build was successful
Details
drone/netlify Preview ready!
Details
@yhuard yhuard deleted the feat/fact-figures-INNO-1927 branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.