Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file): amendments - INNO-1939 #1395

Merged
merged 5 commits into from Nov 8, 2019

Conversation

@emeryro
Copy link
Contributor

emeryro commented Nov 5, 2019

emeryro added 2 commits Nov 7, 2019
@emeryro emeryro marked this pull request as ready for review Nov 7, 2019
@emeryro emeryro requested a review from ec-europa/inno as a code owner Nov 7, 2019
@emeryro emeryro removed their assignment Nov 7, 2019
@degliwe degliwe self-assigned this Nov 7, 2019
@@ -19,10 +19,11 @@
) {
.ecl-file {
margin: 0;
max-width: 823px;

This comment has been minimized.

Copy link
@degliwe

degliwe Nov 7, 2019

Member

Where is this coming from? (can't find it in the specs)
better way to define this?

This comment has been minimized.

Copy link
@emeryro

emeryro Nov 8, 2019

Author Contributor

this value has been provided by the designers, in private message. I asked to put it in the specs too, but it hasn't been done yet.
image

yhuard and others added 2 commits Nov 7, 2019
@yhuard
yhuard approved these changes Nov 8, 2019
@yhuard yhuard merged commit e70ffef into v2-dev Nov 8, 2019
3 checks passed
3 checks passed
Semantic Pull Request ready to be squashed
Details
continuous-integration/drone/push the build was successful
Details
drone/netlify Preview ready!
Details
@yhuard yhuard deleted the fix/file-amendments-INNO-1939 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.