From 3d38efbb3d4028898e070e3becc6d81f825e46c2 Mon Sep 17 00:00:00 2001 From: Alexis Gaillard Date: Tue, 31 May 2022 15:17:50 +0200 Subject: [PATCH 1/4] fix(forms): Add invalid icons for EC and fix them for EU - FRONT-3651 --- .../twig/components/checkbox/README.md | 1 + .../__snapshots__/checkbox.test.js.snap | 528 +----------------- .../checkbox/checkbox-group.html.twig | 1 + .../components/checkbox/checkbox.story.js | 7 +- .../twig/components/checkbox/checkbox.test.js | 50 +- .../__snapshots__/datepicker.test.js.snap | 427 +------------- .../components/datepicker/datepicker.story.js | 7 +- .../components/datepicker/datepicker.test.js | 17 +- .../twig/components/file-upload/README.md | 1 + .../__snapshots__/file-upload.test.js.snap | 11 +- .../file-upload/file-upload.html.twig | 10 +- .../file-upload/file-upload.story.js | 4 +- .../twig/components/radio/README.md | 1 + .../select/__snapshots__/select.test.js.snap | 11 +- .../twig/components/select/select.story.js | 11 +- .../twig/components/select/select.test.js | 4 +- .../__snapshots__/text-area.test.js.snap | 274 +-------- .../components/text-area/text-area.story.js | 7 +- .../components/text-area/text-area.test.js | 17 +- .../__snapshots__/text-input.test.js.snap | 270 +-------- .../components/text-input/text-input.story.js | 7 +- .../components/text-input/text-input.test.js | 15 +- .../vanilla/components/form/_form.scss | 3 +- .../components/checkbox/demo/data--ec.js | 47 -- .../checkbox/demo/{data--eu.js => data.js} | 0 .../components/datepicker/demo/data--ec.js | 14 - .../datepicker/demo/{data--eu.js => data.js} | 0 .../file-upload/demo/data--multiple.js | 5 + src/specs/components/file-upload/demo/data.js | 5 + .../select/demo/data-multiple--ec.js | 60 -- ...{data-multiple--eu.js => data-multiple.js} | 2 +- .../components/select/demo/data-single--ec.js | 55 -- .../{data-single--eu.js => data-single.js} | 0 .../components/text-area/demo/data--ec.js | 13 - .../text-area/demo/{data--eu.js => data.js} | 0 .../components/text-input/demo/data--ec.js | 12 - .../text-input/demo/{data--eu.js => data.js} | 0 37 files changed, 136 insertions(+), 1761 deletions(-) delete mode 100644 src/specs/components/checkbox/demo/data--ec.js rename src/specs/components/checkbox/demo/{data--eu.js => data.js} (100%) delete mode 100644 src/specs/components/datepicker/demo/data--ec.js rename src/specs/components/datepicker/demo/{data--eu.js => data.js} (100%) delete mode 100644 src/specs/components/select/demo/data-multiple--ec.js rename src/specs/components/select/demo/{data-multiple--eu.js => data-multiple.js} (98%) delete mode 100644 src/specs/components/select/demo/data-single--ec.js rename src/specs/components/select/demo/{data-single--eu.js => data-single.js} (100%) delete mode 100644 src/specs/components/text-area/demo/data--ec.js rename src/specs/components/text-area/demo/{data--eu.js => data.js} (100%) delete mode 100644 src/specs/components/text-input/demo/data--ec.js rename src/specs/components/text-input/demo/{data--eu.js => data.js} (100%) diff --git a/src/implementations/twig/components/checkbox/README.md b/src/implementations/twig/components/checkbox/README.md index 6f4f8c24606..db45e021976 100644 --- a/src/implementations/twig/components/checkbox/README.md +++ b/src/implementations/twig/components/checkbox/README.md @@ -23,6 +23,7 @@ npm install --save @ecl/twig-component-checkbox - **"name"** (string) (default: '') - **"helper_id"** (string) (default: '') - **"invalid"** (boolean) (default: false) +- **"invalid_icon"** (object of type "icon") (default: {}) - **"required"** (boolean) (default: false) - **"extra_classes"** (optional) (string) (default: '') Extra classes (space separated) - **"extra_attributes"** (optional) (array) (default: []) Extra attributes diff --git a/src/implementations/twig/components/checkbox/__snapshots__/checkbox.test.js.snap b/src/implementations/twig/components/checkbox/__snapshots__/checkbox.test.js.snap index 84276044c12..395c5939941 100644 --- a/src/implementations/twig/components/checkbox/__snapshots__/checkbox.test.js.snap +++ b/src/implementations/twig/components/checkbox/__snapshots__/checkbox.test.js.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Checkbox EC default renders correctly 1`] = ` +exports[`Checkbox Default renders correctly 1`] = `
`; -exports[`Checkbox EC default renders correctly with extra attributes 1`] = ` - -
- - Select your preferred destinations - - (optional) - - -
- Helper text for the group -
-
- - -
- Helper text for an option -
-
-
- - -
- Helper text for an option -
-
-
- - -
- Helper text for an option -
-
-
- - -
- Helper text for an option -
-
-
-
-`; - -exports[`Checkbox EC default renders correctly with extra class names 1`] = ` - -
- - Select your preferred destinations - - (optional) - - -
- Helper text for the group -
-
- - -
- Helper text for an option -
-
-
- - -
- Helper text for an option -
-
-
- - -
- Helper text for an option -
-
-
- - -
- Helper text for an option -
-
-
-
-`; - -exports[`Checkbox EC renders correctly when invalid 1`] = ` +exports[`Checkbox Default renders correctly when invalid 1`] = `