Skip to content

Remove temple-wallet/dapp dependency from Taquito website #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

danielelisi
Copy link
Contributor

@danielelisi danielelisi commented Dec 2, 2022

This PR disables the live code example for the temple-wallet/dapp library and removes the dependency from website/package.json

We're facing a peer dependency issue with the @temple-wallet/dapp library which is causing npm install in website to fail with the message

lerna ERR! Error: Command failed with exit code 1: npm install --package-lock-only --ignore-scripts
lerna ERR! npm ERR! code ERESOLVE
lerna ERR! npm ERR! ERESOLVE could not resolve
lerna ERR! npm ERR! 
lerna ERR! npm ERR! While resolving: @temple-wallet/dapp@7.0.0
lerna ERR! npm ERR! Found: @taquito/taquito@14.6.0
lerna ERR! npm ERR! node_modules/@taquito/taquito
lerna ERR! npm ERR!   workspace packages/taquito from the root project
lerna ERR! npm ERR!   @taquito/taquito@"^14.6.0" from taquito-test-dapp-vite@14.6.0
lerna ERR! npm ERR!   apps/taquito-test-dapp
lerna ERR! npm ERR!     taquito-test-dapp-vite@14.5.0
lerna ERR! npm ERR!     node_modules/taquito-test-dapp-vite
lerna ERR! npm ERR!       workspace apps/taquito-test-dapp from the root project
lerna ERR! npm ERR!   13 more (@taquito/example, integration-tests, ...)
lerna ERR! npm ERR! 
lerna ERR! npm ERR! Could not resolve dependency:
lerna ERR! npm ERR! peer @taquito/taquito@"^12.0.0" from @temple-wallet/dapp@7.0.0
lerna ERR! npm ERR! website/node_modules/@temple-wallet/dapp
lerna ERR! npm ERR!   @temple-wallet/dapp@"^7.0.0" from @taquito/website@14.6.0
lerna ERR! npm ERR!   website
lerna ERR! npm ERR!     @taquito/website@14.5.0
lerna ERR! npm ERR!     node_modules/@taquito/website
lerna ERR! npm ERR!       workspace website from the root project
lerna ERR! npm ERR! 
lerna ERR! npm ERR! Conflicting peer dependency: @taquito/taquito@12.1.1
lerna ERR! npm ERR! node_modules/@taquito/taquito
lerna ERR! npm ERR!   peer @taquito/taquito@"^12.0.0" from @temple-wallet/dapp@7.0.0
lerna ERR! npm ERR!   website/node_modules/@temple-wallet/dapp
lerna ERR! npm ERR!     @temple-wallet/dapp@"^7.0.0" from @taquito/website@14.6.0
lerna ERR! npm ERR!     website
lerna ERR! npm ERR!       @taquito/website@14.5.0
lerna ERR! npm ERR!       node_modules/@taquito/website
lerna ERR! npm ERR!         workspace website from the root project
lerna ERR! npm ERR! 
lerna ERR! npm ERR! Fix the upstream dependency conflict, or retry
lerna ERR! npm ERR! this command with --force, or --legacy-peer-deps
lerna ERR! npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
lerna ERR! npm ERR! 
lerna ERR! npm ERR! See /home/dan/.npm/eresolve-report.txt for a full report.
lerna ERR! 
lerna ERR! npm ERR! A complete log of this run can be found in:
lerna ERR! npm ERR!     /home/dan/.npm/_logs/2022-12-02T23_17_48_186Z-debug-0.log
lerna ERR!     at makeError (/home/dan/git-projects/ecadlabs/taquito/node_modules/execa/lib/error.js:60:11)
lerna ERR!     at handlePromise (/home/dan/git-projects/ecadlabs/taquito/node_modules/execa/index.js:118:26)
lerna ERR! lerna Command failed with exit code 1: npm install --package-lock-only --ignore-scripts
lerna ERR! lerna npm ERR! code ERESOLVE
lerna ERR! lerna npm ERR! ERESOLVE could not resolve
lerna ERR! lerna npm ERR! 
lerna ERR! lerna npm ERR! While resolving: @temple-wallet/dapp@7.0.0
lerna ERR! lerna npm ERR! Found: @taquito/taquito@14.6.0
lerna ERR! lerna npm ERR! node_modules/@taquito/taquito
lerna ERR! lerna npm ERR!   workspace packages/taquito from the root project
lerna ERR! lerna npm ERR!   @taquito/taquito@"^14.6.0" from taquito-test-dapp-vite@14.6.0
lerna ERR! lerna npm ERR!   apps/taquito-test-dapp
lerna ERR! lerna npm ERR!     taquito-test-dapp-vite@14.5.0
lerna ERR! lerna npm ERR!     node_modules/taquito-test-dapp-vite
lerna ERR! lerna npm ERR!       workspace apps/taquito-test-dapp from the root project
lerna ERR! lerna npm ERR!   13 more (@taquito/example, integration-tests, ...)
lerna ERR! lerna npm ERR! 
lerna ERR! lerna npm ERR! Could not resolve dependency:
lerna ERR! lerna npm ERR! peer @taquito/taquito@"^12.0.0" from @temple-wallet/dapp@7.0.0
lerna ERR! lerna npm ERR! website/node_modules/@temple-wallet/dapp
lerna ERR! lerna npm ERR!   @temple-wallet/dapp@"^7.0.0" from @taquito/website@14.6.0
lerna ERR! lerna npm ERR!   website
lerna ERR! lerna npm ERR!     @taquito/website@14.5.0
lerna ERR! lerna npm ERR!     node_modules/@taquito/website
lerna ERR! lerna npm ERR!       workspace website from the root project
lerna ERR! lerna npm ERR! 
lerna ERR! lerna npm ERR! Conflicting peer dependency: @taquito/taquito@12.1.1
lerna ERR! lerna npm ERR! node_modules/@taquito/taquito
lerna ERR! lerna npm ERR!   peer @taquito/taquito@"^12.0.0" from @temple-wallet/dapp@7.0.0
lerna ERR! lerna npm ERR!   website/node_modules/@temple-wallet/dapp
lerna ERR! lerna npm ERR!     @temple-wallet/dapp@"^7.0.0" from @taquito/website@14.6.0
lerna ERR! lerna npm ERR!     website
lerna ERR! lerna npm ERR!       @taquito/website@14.5.0
lerna ERR! lerna npm ERR!       node_modules/@taquito/website
lerna ERR! lerna npm ERR!         workspace website from the root project
lerna ERR! lerna npm ERR! 
lerna ERR! lerna npm ERR! Fix the upstream dependency conflict, or retry
lerna ERR! lerna npm ERR! this command with --force, or --legacy-peer-deps
lerna ERR! lerna npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
lerna ERR! lerna npm ERR! 
lerna ERR! lerna npm ERR! See /home/dan/.npm/eresolve-report.txt for a full report.
lerna ERR! lerna 
lerna ERR! lerna npm ERR! A complete log of this run can be found in:
lerna ERR! lerna npm ERR!     /home/dan/.npm/_logs/2022-12-02T23_17_48_186Z-debug-0.log

Removing this dependency from our website package solves the issue

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for taquito-test-dapp canceled.

Name Link
🔨 Latest commit aecf1a3
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/638a8b80aeafa0000aad8586

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/remote-signer@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tezbridge-signer@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tezbridge-wallet@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@14.2.0-63430dbd--2202 --registry https://npm.preview.tezostaquito.io/

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

A new deploy preview is available on Netlify at https://63430db--tezostaquito.netlify.app

@danielelisi danielelisi merged commit 9195e4f into master Dec 2, 2022
@danielelisi danielelisi deleted the disable_temple_wallet_live_example branch December 2, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant