Run integration test against testnets for external PRs - #2221
Merged
Conversation
✅ Deploy Preview for taquito-test-dapp canceled.
|
Contributor
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
Contributor
|
A new deploy preview is available on Netlify at https://73260ca--tezostaquito.netlify.app |
danielelisi
force-pushed
the
skip_test_public_endpoint
branch
from
December 9, 2022 01:08
b0a3eb1 to
a1ca984
Compare
danielelisi
force-pushed
the
skip_test_public_endpoint
branch
from
December 14, 2022 01:01
0ce44bd to
8934c4b
Compare
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| # TODO: remove after debugging |
Collaborator
There was a problem hiding this comment.
Should this be deleted?
Contributor
Author
There was a problem hiding this comment.
ah thanks for catching it! removed the debug statements
roxaneletourneau
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External PRs from users outside our
ecadlabsGH org don't have access to GH Secrets. This is an intended behaviour to avoid exposing sensitive keys and tokens to third parties.We block some resource-intensive RPC endpoints from our public-facing nodes. Since some integration tests need to contact these RPC endpoints we let GH runners join our private network and contact internal RPC Tezos nodes directly. GH Runners use GH Secrets to join our Tailscale private network.
This PR refactors the GH workflows and skips the
baking_rightsandendorsing_rightstests when an external user submits a PR to Taquito. Additionally, we set the keygenkeyURLto point to the publicly accessible keygen instance so that we can request keys without having to login to our private network.I've also added a condition to skip the
deploy-edge-packageworkflow on external PRs. Similarly to what I mentioned above, Github Secrets aren't available on external PRs and this job would always fail as it requires a secret to publish the packages on Verdaccio. Also, this is a security consideration as we don't want to allow external users to arbitrarily publish packages to an NPM registry.Test Plan
Opened a PR as an external contributor and confirmed that:
Example workflow run from an external PR https://github.com/ecadlabs/taquito/pull/2223/checks