-
Notifications
You must be signed in to change notification settings - Fork 119
Run integration test against testnets for external PRs #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for taquito-test-dapp canceled.
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
A new deploy preview is available on Netlify at https://73260ca--tezostaquito.netlify.app |
b0a3eb1
to
a1ca984
Compare
0ce44bd
to
8934c4b
Compare
.github/workflows/main.yml
Outdated
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: 16 | ||
# TODO: remove after debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thanks for catching it! removed the debug statements
External PRs from users outside our
ecadlabs
GH org don't have access to GH Secrets. This is an intended behaviour to avoid exposing sensitive keys and tokens to third parties.We block some resource-intensive RPC endpoints from our public-facing nodes. Since some integration tests need to contact these RPC endpoints we let GH runners join our private network and contact internal RPC Tezos nodes directly. GH Runners use GH Secrets to join our Tailscale private network.
This PR refactors the GH workflows and skips the
baking_rights
andendorsing_rights
tests when an external user submits a PR to Taquito. Additionally, we set the keygenkeyURL
to point to the publicly accessible keygen instance so that we can request keys without having to login to our private network.I've also added a condition to skip the
deploy-edge-package
workflow on external PRs. Similarly to what I mentioned above, Github Secrets aren't available on external PRs and this job would always fail as it requires a secret to publish the packages on Verdaccio. Also, this is a security consideration as we don't want to allow external users to arbitrarily publish packages to an NPM registry.Test Plan
Opened a PR as an external contributor and confirmed that:
Example workflow run from an external PR https://github.com/ecadlabs/taquito/pull/2223/checks