Skip to content

Pull code from axios-fetch-adapter into http-utils #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2023

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Apr 27, 2023

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 6d66e74
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/6467e96dec4a970007b5fa5c
😎 Deploy Preview https://deploy-preview-2457--taquito-test-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/http-utils@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@16.1.2-b5bcf89-- --registry https://npm.preview.tezostaquito.io/

@ac10n ac10n force-pushed the pull-code-from-axios-fetch-adapter branch from 178fd26 to e132b52 Compare May 2, 2023 16:31
@github-actions
Copy link

github-actions bot commented May 2, 2023

A new deploy preview is available on Netlify at https://b5bcf89--tezostaquito.netlify.app

@ac10n ac10n requested a review from dsawali May 3, 2023 03:30
@dsawali dsawali requested a review from danielelisi May 3, 2023 20:16
Copy link
Contributor

@danielelisi danielelisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the signature.json files? It seems like an unrelated change for this PR.

I don't exactly know what these signatures files are used for but I'd suggest making a separate PR to remove them. So that in case we later realize they are needed we can easily revert the PR.

@ac10n ac10n force-pushed the pull-code-from-axios-fetch-adapter branch from c04ee2c to d23b274 Compare May 3, 2023 22:03
@ac10n
Copy link
Contributor Author

ac10n commented May 3, 2023

Why are you removing the signature.json files? It seems like an unrelated change for this PR.

I don't exactly know what these signatures files are used for but I'd suggest making a separate PR to remove them. So that in case we later realize they are needed we can easily revert the PR.

Agree. Reverted the commit

@ac10n ac10n force-pushed the pull-code-from-axios-fetch-adapter branch from d23b274 to 6d66e74 Compare May 19, 2023 21:26
@ac10n ac10n merged commit 15fb656 into master May 19, 2023
@ac10n ac10n deleted the pull-code-from-axios-fetch-adapter branch May 19, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants