1994 taquito package error improvement #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-package-error-improvement
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
|
A new deploy preview is available on Netlify at https://d464463--tezostaquito.netlify.app |
ac10n
reviewed
Jul 10, 2023
ac10n
reviewed
Jul 10, 2023
ac10n
reviewed
Jul 10, 2023
| super(); | ||
| this.name = 'InvalidTokenMetadata'; | ||
| this.message = | ||
| 'Non-compliance with the TZIP-012 standard. The required property `decimals` is missing.'; |
There was a problem hiding this comment.
I think it's useful to add the Token Metadata that has cause the failure. That helps the user diagnose their problem.
dsawali
reviewed
Jul 10, 2023
| @@ -55,7 +55,7 @@ export class InvalidAddressError extends ParameterValidationError { | |||
| super(); | |||
| this.name = 'InvalidAddressError'; | |||
| this.message = `Invalid address "${address}"`; | |||
| errorDetail ? (this.message += ` ${errorDetail}.`) : null; | |||
| this.message += errorDetail ? ` ${errorDetail}.` : '.'; | |||
There was a problem hiding this comment.
what does an example of an error message for this look like?
There was a problem hiding this comment.
something like this Invalid address "tz1iedjFYksExq8snZK9MNo4AvXHG" failed checksum.
| @@ -147,14 +147,14 @@ describe('Metadata provider test', () => { | |||
| done(); | |||
| }); | |||
|
|
|||
| it('Should fail with InvalidMetadata when metadata are not a JSON object', async (done) => { | |||
| it('Should fail with InvalidContractMetadata when metadata are not a JSON object', async (done) => { | |||
There was a problem hiding this comment.
I think it should be 'is not a JSON object'
ac10n
reviewed
Jul 10, 2023
| super(); | ||
| this.name = 'BigMapMetadataNotFound'; | ||
| this.message = | ||
| 'Non-compliance with the TZIP-016 standard. No big map named metadata was found in the contract storage.'; |
There was a problem hiding this comment.
Same here, including the data can help with diagnostincs
ac10n
reviewed
Jul 10, 2023
| * @category Error | ||
| * @description Error indicates missing big map metadata (non compliance to the TZIP-16 standard) | ||
| */ | ||
| export class BigMapMetadataNotFound extends TaquitoError { |
There was a problem hiding this comment.
There is a bit of inconsistency in this file: Some classes end with Error while others don't
ac10n
reviewed
Jul 10, 2023
| @@ -97,7 +97,7 @@ export const createOriginationOperation = async ({ | |||
| }; | |||
|
|
|||
| if (isNaN(Number(balance))) { | |||
| throw new IntegerError(`Unexpected Invalid Integer ${balance}`); | |||
| throw new InvalidBalanceError(`Invalid Balance "${balance}", can't convert to a number`); | |||
There was a problem hiding this comment.
Suggested change
| throw new InvalidBalanceError(`Invalid Balance "${balance}", can't convert to a number`); | |
| throw new InvalidBalanceError(`Invalid Balance "${balance}", cannot be converted to a number`); |
dsawali
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.
error improvement of package @taquito/taquito, @taquito/tzip12 and @taquito/tzip16
Breaking Changes: