Skip to content

Comments #828

Open
Open

Description

@manuelmeister

Allow users to give feedback on activities.

Variants:

  1. Simple activity content
  2. Multiple comment types (Activity Comment, Day Comment, Material Comment, …)
  3. Generic comment type with a reference to the respective entities.

Activity

  1. added this to the Post-MVP (v3.x) milestone on Jan 16, 2021
  2. manuelmeister commented on Apr 12, 2025

    @manuelmeister
    MemberAuthor

    Feedback/Comments

    MVP:

    Advanced:

    • I'm able to resolve/hide any comment?
    • I'm able to mark as read/unread (only for me)
    • I'm able to reply
    • I'm able to edit comments?
    • I'm able to assign / mention?
    • Overview page with activity comments
    • Show me comments on objects I'm responsible
    • I can see that new comments have been made
    • Dashboard filter for comments
    • Comment overview for all camps

    Ideas:

  3. pinned this issue on Apr 13, 2025
  4. manuelmeister commented on Jun 24, 2025

    @manuelmeister
    MemberAuthor

    We've got feedback, that users want to have a comments overview similar to eCamp v2.

  5. unpinned this issue on Apr 12, 2026
  6. added
    agents:ignoreThis issue is not ready for automated implementation, and AI agents should not work on this.
    on Jun 13, 2026
  7. BacLuc commented on Jun 23, 2026

    @BacLuc
    Contributor
  8. carlobeltrame commented on Jul 23, 2026

    @carlobeltrame
    Member

    Priority todo list for the frontend implementation:

  9. self-assigned this
    on Aug 1, 2026
  10. manuelmeister commented on Aug 8, 2026

    @manuelmeister
    MemberAuthor

    Offline Discussion

    Vision discussion by @carlobeltrame and @manuelmeister for comments UX/UI

    Vision

    We primarily focused on desktop. We identified the following important functionalities:

    • A: Camp Manager & J+S Coach can create comments anchored to an activity, part of an activity, the whole camp or other entities
    • B: While creating a comment, the user needs to see the context of the commented content and previous comments
    • C: Everyone should be able to easily view comments on the current visible entity, especially the ones they are responsible for
    • D: Any comments should only be shown where we have enough context (such as activity comments in the activity detail view)
    • E: Everyone should be able to resolve comments
    • F: Resolved comments should be hidden by default, but discoverable
    • G: When a commented entity is deleted, the comments become detached but should still be visible and not automatically be resolved
    • H: The user is only able to indefinitely delete their comments
    • I: Everyone should be able to reply to a "non-reply"-comment (thus comment nesting depth is 1)
    • J: To work through feedback/tasks, the user should see the whole list of comments of their responsibilities.
    • K: To have an overview of the current state of the planning, camp managers and J+S coaches need to be able to list all comments and to be able to filter by various criteria (resolved, period, detatched)
    • L: The comment tries to stay attached as close to the initial entity/anchor as possible (uses a fallback system camp<activity<contentnode<path)
    • M: Activity-orphaned comments need to be separately visible along side the "whole camp level" comments
    • N: Users want to see an indication for new comments

    Todos / Decisions

    • Put category shortName into orphanDescription to help remember deleted activity contents
    • orphanDescription should happen on comment creation instead of activity deletion
    • Replace orphanDescription with columns for each entity referenced in the comment called entity_CONTEXT that saves a human readable snapshot summary of the referenced entity at the time of comment creation. This way on foreign deletion, we can give the user some context. If a comment is anchored to a text range, we also store the human readable snapshot of that text range in the column anchor_context.
    • On ActivityRow comment button click, it should navigate to the activity, open the comment panel and focus it
    • CommentPanel on Desktop: in non-activity-detail views we hide activity/contentnode/... comments, and instead add a small notice of the additional comments in each activity
    • CommentPanel on Mobile: show all comments
    • Mobile comments panel should be fullscreen
    • Mobile comments panel should also have Filters/Sorting/... (for the moment only filterable by author, and resolved status)
    • Mobile comments panel on camp level should include all comments of any entity/deleted activities of this camp
    • When opening the CommentPanel on the Dashboard on Mobile via a button on an ActivityRow, display only the comments related to that activity (filter by that activity)
    • Comment background color use avatar color with hsl to help
      function lightenColor(color, lightness = 95) {
       const input = new Color(color)
       input.hsl.l=lightness
       return input.toString({ format: 'hex' })
      }

    Open Questions

    • Mobile: Should I be able to resize comment panel, or fullscreen by default? -> fullscreen, we don't have space either way on mobile to display the whole necessary context
    • Period comments?
  11. manuelmeister commented on Aug 11, 2026

    @manuelmeister
    MemberAuthor

    Core Meeting Decision

    • Comments on activity can't have period reference. If we want a period reference then we can still do that.
    • We want to merge and ship this pretty soon, there are some minor changes needed.
    • Hide activity comments in whole camp comment overview
    • We discussed what happens to detached comments (especially for all snapshot context), but did not yet find a common ground and are going forward with this as it is now (with shortName of category).
    • We agreed that comments on text ranges should persist the text range content at comment creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EpicFeature requestagents:ignoreThis issue is not ready for automated implementation, and AI agents should not work on this.next-milestone

Type

No type

Projects

  • Status
    No status

Relationships

None yet

Development

No branches or pull requests

Issue actions