This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
require memo on exchange account #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feruzm
reviewed
Jul 17, 2023
| // Check memo if selected is an exchange account | ||
| if (exchangeAccounts.includes(to)) { | ||
| this.stateSet({ toExchangeError: _t("transfer.memo-required") }); | ||
| console.log(this.state.toExchangeError) |
There was a problem hiding this comment.
@Adesojisouljay need to clean up logs
There was a problem hiding this comment.
Logs cleaned
…into feat/memo-on-exchange-transfers
…into feat/memo-on-exchange-transfers
feruzm
reviewed
Jul 20, 2023
src/common/i18n/locales/en-US.json
Outdated
| @@ -1218,6 +1218,7 @@ | |||
| "memo-placeholder": "enter your notes here", | |||
| "memo-help": "This memo is public", | |||
| "memo-error": "Never put private keys into a memo field, it is publicly visible to everyone.", | |||
| "memo-required": "Transfer to an exchannge account must include a memo.", | |||
There was a problem hiding this comment.
@Adesojisouljay typo on exchange. Make it: Transfer to an exchange must have a memo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hat does this PR?
Presently transferring to exchange accounts doesn't request for memo,
This PR fixes that.
Github issue
Video/Screenshot
memoissue.mp4
exchangememofixes.mp4