From c9629872e013958b4f9b72f97a55be59b62e5c56 Mon Sep 17 00:00:00 2001 From: Johnny Huynh <27847622+johnnyhuy@users.noreply.github.com> Date: Sun, 14 Jul 2024 08:35:53 +1000 Subject: [PATCH 1/5] chore: Refactor project configuration settings - Delete unused .release-it.json configuration file - Clean up project by removing unnecessary files --- .release-it.json | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 .release-it.json diff --git a/.release-it.json b/.release-it.json deleted file mode 100644 index 2cd8f78..0000000 --- a/.release-it.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "$schema": "https://unpkg.com/release-it@17/schema/release-it.json", - "github": { - "release": false - }, - "npm": false -} \ No newline at end of file From 3a57a37fb9e082f328c35f91a4a31fd44af79314 Mon Sep 17 00:00:00 2001 From: Johnny Huynh <27847622+johnnyhuy@users.noreply.github.com> Date: Sun, 14 Jul 2024 08:44:54 +1000 Subject: [PATCH 2/5] refactor: Refactor Plausible configuration properties and URLs - Refactored PlausibleAnalytics component to use dataDomain and sourceDomain properties - Updated Config interface to include sourceDomain property - Updated plugin test cases to reflect changes in configuration properties --- plugins/plausible/config.d.ts | 7 ++++++- .../src/components/PlausibleAnalytics.tsx | 14 +++++--------- plugins/plausible/src/plugin.test.tsx | 5 +++-- 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/plugins/plausible/config.d.ts b/plugins/plausible/config.d.ts index e809364..8f1067a 100644 --- a/plugins/plausible/config.d.ts +++ b/plugins/plausible/config.d.ts @@ -8,6 +8,11 @@ export interface Config { /** * @visibility frontend */ - domain: string; + dataDomain: string; + + /** + * @visibility frontend + */ + soureDomain: string; }; } diff --git a/plugins/plausible/src/components/PlausibleAnalytics.tsx b/plugins/plausible/src/components/PlausibleAnalytics.tsx index c2ec17c..b326847 100644 --- a/plugins/plausible/src/components/PlausibleAnalytics.tsx +++ b/plugins/plausible/src/components/PlausibleAnalytics.tsx @@ -4,17 +4,13 @@ import React from 'react'; export const PlausibleAnalytics = () => { const config = useApi(configApiRef); const enabled = config.getOptionalBoolean('plausible.enabled') ?? false; - const domain = config.getOptionalString('plausible.domain'); + const dataDomain = config.getOptionalString('plausible.dataDomain'); + const sourceDomain = config.getOptionalString('plausible.sourceDomain'); + const source = `https://${sourceDomain}/js/script.js`; - if (!enabled || !domain) { + if (!enabled || !dataDomain || !sourceDomain) { return null; } - return ( -