Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Implement JS support for assemblies #6929

Closed
quintesse opened this issue Feb 23, 2017 · 8 comments
Closed

Implement JS support for assemblies #6929

quintesse opened this issue Feb 23, 2017 · 8 comments
Assignees
@quintesse
Labels
c-tools
Milestone
1.3.2

Comments

@quintesse
Copy link
Contributor

Right now we only support ceylon run --assembly, the same should work for ceylon run-js
@quintesse quintesse added this to the 1.3.2 milestone Feb 23, 2017
@quintesse quintesse self-assigned this Feb 23, 2017
@gavinking
Copy link
Contributor

+1

@quintesse
Copy link
Contributor Author

I've made this work for combined JVM/JS modules but JS-only modules are giving trouble unfortunately. Something to do with the code I copied from Stef.

@FroMage: is there a way to use the ModelGraph visitor to visit JS-only modules? It encounters 1st-level JS modules but they doesn't have an ArtifactResult associated with them and neither are their dependencies walked. Is that a known issue?

@gavinking
Copy link
Contributor

Excellent work, @quintesse!

@quintesse
Copy link
Contributor Author

Sorry, this isn't really done yet

@quintesse quintesse reopened this Feb 24, 2017
@FroMage
Copy link
Contributor

FroMage commented Feb 24, 2017

Honestly I don't remember. There's no reason to not walk them AFAICT.

quintesse added a commit that referenced this issue Feb 24, 2017
@quintesse
Make it easy to override the set of Aritfact types a ModuleLoader can…
5f0981f 
… handle (see #6929)
quintesse added a commit that referenced this issue Feb 24, 2017
@quintesse
Make sure the DpendencyResolvers don't throw exceptions when dealin…
893839e 
…g with artifact types they don't know how to handle (see #6929)
quintesse added a commit that referenced this issue Feb 24, 2017
@quintesse
The AssemblyRepositoryBuilder now also handles NPM modules bundled …
e302053 
…in assemblies (#6929)
quintesse added a commit that referenced this issue Feb 24, 2017
@quintesse
The assemble tool now adds NPM modules to the output as well (#6929)
dff4883
@quintesse
Copy link
Contributor Author

Ok, assemblies now not only can hold Ceylon JS modules but even NPM modules.

Unfortunately we don't have an NpmDependencyResolver in the CMR yet so we can't retrieve an NPM module's dependencies so for now this only works for very simple NPM modules.

quintesse added a commit that referenced this issue Feb 28, 2017
@quintesse
Added an NPM resolver / module info reader (#6929)
08b4ae0
quintesse added a commit that referenced this issue Feb 28, 2017
@quintesse
Shouldn't fail getting module info when one of the resolvers throws a…
f4d923c 
…n exception (#6929)
quintesse added a commit that referenced this issue Feb 28, 2017
@quintesse
We now retrieve module info + dependencies from NPM artifacts (#6929)
ef960c0
@quintesse
Copy link
Contributor Author

Ok, this now works for non-trivial NPM modules as well. Closing.

@gavinking
Copy link
Contributor

Great! Thanks @quintesse!

FroMage added a commit that referenced this issue Jun 7, 2017
@FroMage
Work on zip/jar/car files in resolvers #6929 #7084
eb22c30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@quintesse quintesse

Labels
c-tools
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
3 participants
@FroMage @gavinking @quintesse