Skip to content
This repository has been archived by the owner. It is now read-only.

added sumSince (fixes #1843 replaces #376) #1854

Merged
merged 2 commits into from Jul 12, 2016

Conversation

@watou
Copy link
Contributor

@watou watou commented Jul 11, 2016

  • added sumSince (fixes #1843 replaces #376)
  • changed averageSince to use BigDecimal instead of double
  • changed evolutionRate to use BigDecimal instead of double
  • changed deltaSince to use BigDecimal instead of double
  • added check in evolutionRate method to avoid divide-by-zero error
  • updated all JavaDoc headers to reflect the odd variety of return values and their reasons, in hopes of spurring discussion as to whether and how to tighten and simplify the PersistenceExtensions.

Also-By: Jan N. Klug jan.n.klug@rub.de
Signed-off-by: John Cocula john@cocula.com

* added sumSince (fixes eclipse-archived#1843 replaces eclipse-archived#376)
* changed evolutionRate to use BigDecimal instead of double
* changed deltaSince to use BigDecimal instead of double
* added check in evolutionRate method to avoid divide-by-zero error
* updated all JavaDoc headers to reflect the odd variety of return values and their reasons, in hopes of spurring discussion as to whether and how to tighten and simplify the PersistenceExtensions.

Also-By: Jan N. Klug jan.n.klug@rub.de
Signed-off-by: John Cocula <john@cocula.com>
@maggu2810
Copy link
Contributor

@maggu2810 maggu2810 commented Jul 12, 2016

Overall it looks good.
One remarks:
Can you change the modifiers to the common order (public static instead of static pulic).
The currently used order has not been changed or introduced by you, but as you already touched the function it is perhaps a good time to use a common one. WDYT?
I know there is no "wrong" but there is a suggestion for the order http://checkstyle.sourceforge.net/config_modifier.html

Signed-off-by: John Cocula <john@cocula.com>
@maggu2810 maggu2810 merged commit c362f8a into eclipse-archived:master Jul 12, 2016
2 checks passed
@maggu2810
Copy link
Contributor

@maggu2810 maggu2810 commented Jul 12, 2016

Thanks

@watou watou deleted the add-sumSince branch Jul 12, 2016
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants