Skip to content
This repository has been archived by the owner. It is now read-only.

Add LIFX Thing properties #3324

Merged
merged 1 commit into from May 5, 2017
Merged

Add LIFX Thing properties #3324

merged 1 commit into from May 5, 2017

Conversation

@wborn
Copy link
Contributor

@wborn wborn commented Apr 27, 2017

This PR adds adds the following Thing properties to LIFX lights:

  • hostVersion
  • macAddress
  • productId
  • productName
  • productVersion
  • vendorId
  • vendorName
  • wifiVersion
  • zones (only for lights that have MultiZone control, e.g. LIFX Z)

All properties (except for zones) are added during discovery. Apparently new property values from discovery results are not updated. E.g. when you would manually update the firmware via the LIFX app. Also these properties are not added to Things that already exist. I've submitted issue #3323 for this.

Furthermore I've removed the StateMeshFirmwareResponse GetMeshFirmwareRequest packets because these are remnants of the old LIFX protocol. StateMeshFirmwareResponse causes issues when response packets are received because it has the same packet type as StateHostFirmwareResponse.

LifxLightDiscovery will now also detect and skip lights that are not yet supported by the binding.

Signed-off-by: Wouter Born <eclipse@maindrain.net>
Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit f7155c4 into eclipse-archived:master May 5, 2017
2 checks passed
@wborn wborn deleted the lifx-thing-properties branch May 9, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Jun 24, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Jun 24, 2017
@kaikreuzer kaikreuzer removed this from the 0.9.0 milestone Jun 26, 2017
@kaikreuzer kaikreuzer removed this from the 0.9.0 milestone Jun 26, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Jun 26, 2017
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants